Giter Club home page Giter Club logo

Comments (3)

ig-sinicyn avatar ig-sinicyn commented on June 14, 2024 1

@zihotki

Great point!

Well, technically there is no problem as MIT license does allow to mix code under different licenses and we have ensured that all sources issued under Apache license have a license info applied.

We definitely should have a notice and here's a stub for it. Should be improved, though.

AFAIR there is no common guideline for mixing two licenses in same project. If understand the Apache license literally, our code is fine. Quoting the Apache license

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file
and
APPENDIX: How to apply the Apache License to your work.
To apply the Apache License to your work, attach the following boilerplate notice ...

The first is easy one as the Roslyn does not contain Notice document and the second is done already.

Proofs:
https://www.quora.com/Is-the-MIT-license-compatible-with-the-Apache-License-Version-2-APLv2
http://softwareengineering.stackexchange.com/questions/297217/using-code-under-apache-2-0-license-in-my-program-using-mit-license

Any ideas what to do further?

@rsdn/codejam : do we need the ObjectPool part at all? 😕

from codejam.

zihotki avatar zihotki commented on June 14, 2024 1

Also to not forget, the package on NuGet should also be updated somehow to include the notice. But I'm not sure how they suggest to solve such cases.

from codejam.

ig-sinicyn avatar ig-sinicyn commented on June 14, 2024 1

@zihotki
Well, here is what we've done so far:

  • We removed the code issued under Apache license. It turns out the ObjectPool was included as a stub implementation and was not used at all.

  • I've added 'Notices' section to the readme.md listing all places that refer to third-party code and checked that all such files have a license section on top of it,

If that's ok I'm going to close the issue.

from codejam.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.