Giter Club home page Giter Club logo

Comments (5)

rrthomas avatar rrthomas commented on September 2, 2024

Thanks for this report. Would it have been easier to write if it had been more automated? It would have been easier to read if it had been more automated, for example, with a line number reference.

The obvious solution to me seems to be to cast the second argument to void, then it is the same type as the third.

from lrexlib.

tautschnig avatar tautschnig commented on September 2, 2024

Thanks a lot for the quick fix; indeed I should have included line number information, sorry about this.

Best,
Michael

from lrexlib.

tautschnig avatar tautschnig commented on September 2, 2024

Hello,

May I dare reopen this issue? It seems there are more files suffering from the very same problem. It's these lines here:

https://github.com/rrthomas/lrexlib/blob/master/src/tre/ltre.c#L41
https://github.com/rrthomas/lrexlib/blob/master/src/tre/ltre_w.c#L44
https://github.com/rrthomas/lrexlib/blob/master/src/posix/lposix.c#L64
https://github.com/rrthomas/lrexlib/blob/master/src/pcre/lpcre.c#L51
https://github.com/rrthomas/lrexlib/blob/master/src/gnu/lgnu.c#L53

All of them should easily be fixed in the same way as lonig.c was, i.e., by inserting a (void) in front of ALG_PUSHSUB.

Best,
Michael

from lrexlib.

rrthomas avatar rrthomas commented on September 2, 2024

Thanks; please submit a pull request.

from lrexlib.

tautschnig avatar tautschnig commented on September 2, 2024

My apologies for the delay; this is now done, you should be able to find it among the pull requests.

Best,
Michael

from lrexlib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.