Giter Club home page Giter Club logo

Comments (3)

depaolim avatar depaolim commented on June 7, 2024

A proposal:

from django.db import close_old_connections, reset_queries, transaction
import rq


class TransactionWorker(rq.Worker):
    def perform_job(self, job):
        reset_queries()
        close_old_connections()
        try:
            with transaction.atomic():
                super(TransactionWorker, self).perform_job(job)
        finally:
            close_old_connections()

I have extended a bit the scope of this ticket
It is important to re-assure there is a valid DB connection
At the moment if the rqworker loses the db connection you should restart it
But django request/response cycle has already the ability to reconnect:
https://github.com/django/django/blob/master/django/db/__init__.py

So I propose to use the same functions inside a new django_rq.TransactionWorker

from django-rq.

depaolim avatar depaolim commented on June 7, 2024

... Maybe the "transaction.atomic" could be activated only if settings.DATABASES["default"]["ATOMIC_REQUESTS"] is set ...

from django-rq.

depaolim avatar depaolim commented on June 7, 2024

I changed my mind. I think it is better I don't overlap responsibilities between transaction-management and connection-management
The user should simply simply use the decorator transaction.atomic to wrap job execution in a Django transaction
In this way it is up to the user to correctly decorate the function enqueued and django-rq can be agnostic about it
I propose to close this ticket
On the other side, the connection management should be up to the framework: the same policy django uses to manage databases and connections should be used by django-rq workers
I have created another ticket specific to this last issue: #216

from django-rq.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.