Giter Club home page Giter Club logo

Comments (5)

mgrunberg avatar mgrunberg commented on June 12, 2024 1

@yoavniran tested and v1.4.0-rc1 solves my issue! Thanks!

from react-uploady.

yoavniran avatar yoavniran commented on June 12, 2024

thanks @mgrunberg
Thats surprising but definitely looks like a bug.
I will investigate

from react-uploady.

mgrunberg avatar mgrunberg commented on June 12, 2024

@yoavniran thanks for your quick response.

I found a workaround: listen to batch cancelation and call abort.
I can do this because my validations are the only source of batch cancelations.

import Uploady, { UPLOADER_EVENTS, useAbortBatch, useBatchCancelledListener } from '@rpldy/uploady';
import UploadButton from '@rpldy/upload-button';
import { getMockSenderEnhancer } from '@rpldy/mock-sender';
import UploadPreview from '@rpldy/upload-preview';

const mockSenderEnhancer = getMockSenderEnhancer({
  delay: 500,
});

function Workaround() {
  const abortBatch = useAbortBatch();

  useBatchCancelledListener((batch) => {
    abortBatch(batch.id)
  });

  return null;
}

const listeners = {
  [UPLOADER_EVENTS.BATCH_ADD]: (batch) => {
    return batch.items.length < 2;
  },
};

export default function App() {
  return (
    <Uploady
      enhancer={mockSenderEnhancer}
      listeners={listeners}
      maxConcurrent={3}
    >
      <div className="files">
        <UploadPreview rememberPreviousBatches />
        <Workaround />
      </div>
      <UploadButton />
    </Uploady>
  );
}

I hope this helps in the investigation.

from react-uploady.

yoavniran avatar yoavniran commented on June 12, 2024

thanks. its actually a very simple bug and yet surprising that nor I or anyone else encountered it (at least not that was reported)
I should have a fix soon. It will go into the 1.4.0 RC soon as well

from react-uploady.

yoavniran avatar yoavniran commented on June 12, 2024

@mgrunberg v1.4.0-rc.1 is available now with the fix.
Would be great if you can give it a try and let me know it solves your issue

from react-uploady.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.