Bug in font dropdown about chrome-minimal-bookmarks-tree HOT 10 CLOSED

not @oleed but @oleedd

from chrome-minimal-bookmarks-tree.

Pull request opened: #95

from chrome-minimal-bookmarks-tree.

I don't think it is a good way to check all fonts. It is not optimal. The best way is to set the default font css to this <option> element when you create it.

from chrome-minimal-bookmarks-tree.

The problem is that if I don't check for __default__ then the extension will set the font-family for the select to the font __default__, which doesn't exist, but causes the browser to render some other font than the default (no idea which is selects).

I agree that setting a default would be better, but it's system dependent, so I can't know for all computers what their default font is, so I can't supply one.

It is not optimal.

Correct, but it's not like people use this several times a day, I'm sure they can wait an extra few milliseconds when they want to change the font 😉

from chrome-minimal-bookmarks-tree.

Maybe you can use just this after <select> with all fonts is built:
dropdowns[0].style.fontFamily = "revert"
I think rewriting is better than many checks.
Also it is better to create the "Default" option not in a html file but using JS after <select> with all fonts is built. It makes no problems.

from chrome-minimal-bookmarks-tree.

dropdowns[0].style.fontFamily = "revert"

That just replaces the CSS, the checking against __default__ would still be needed.

Also it is better to create the "Default" option not in a html file but using JS after <select> with all fonts is built. It makes no problems.

It doesn't really matter. Since it must be there always I prefer it in the HTML as that makes it more clear that it will always be there. It's really not important though.

from chrome-minimal-bookmarks-tree.

OK. An iron working way:
font.children[0].style.fontFamily = "revert"
Or to use "fontList" here:

I have checked this and it works. So only one string fixes this issue without any additional checks.

from chrome-minimal-bookmarks-tree.

No it does not. The issue is that it sets font-family: __default__ on the <select> element. Your fix does not solve that.

It's fine as is. I don't care about an extremely minor performance thing in a settings form. I didn't actually notice any delay.

Don't fix something that isn't broken.

from chrome-minimal-bookmarks-tree.

Ah, I get it now. It's just that I didn't understand because you solved in the javascript what I would have solved in the HTML.

I've solved it in the HTML now: #100

Thanks 👍

from chrome-minimal-bookmarks-tree.

Oh. I meant exactly that initially 👍

Don't fix something that isn't broken.

Not possible to fix something that isn't broken. It is only about improving.

from chrome-minimal-bookmarks-tree.