Don't multiply height/width by zoom level about chrome-minimal-bookmarks-tree HOT 35 CLOSED

Fixed

from chrome-minimal-bookmarks-tree.

The pop-up size is still not the same at different zoom. I don't see changes after the update visually.
It also causes that if zoom < 100 - then not possible to use max height/width.

from chrome-minimal-bookmarks-tree.

It seems it is setting the correct width/height in pixels, but since zoom > 100 it is multiplied by (zoom / 100), so 300px with zoom 200 will become 300 * (200 / 100) = 600 🙁

I think I'm going to remove the "zoom" option and add a "font size" option and only scale using that. What do you think?

from chrome-minimal-bookmarks-tree.

No way to fix zoom?
About the "front size" option - I plan to make a cool mini-project with such name - but it is difficult and need to learn some things to give a clear solution. The sense is to zoom only the font without zooming anything else because now some nice but small fonts look like this:

or

And not possible to read something but there is much free space between strings.

from chrome-minimal-bookmarks-tree.

There is a way to fix zoom, but using font size is a LOT easier, as you don't have to use the zoom in each and every calculation about width and height.

Plus, I rather doubt people are actually using zoom now, given the amount of bugs that were in there and the fact that no one reported them (apart from you, but I'm not sure you actually use it?)

from chrome-minimal-bookmarks-tree.

I don't use zoom but it is a very interesting option in terms of the programming aspect. Also, it is useful for those who have bad eyesight. I think I can fix it. It should be interesting.
What about my mini-project for small fonts above? I can't name it in a different way than "font size".

from chrome-minimal-bookmarks-tree.

I'm not sure how to solve your problem. Fonts are hard. I'd be interested to hear what you find!

from chrome-minimal-bookmarks-tree.

It is very difficult to solve this but I got a css solution (probably the only possible). But I want to first understand how it works. When done I will open an issue with explanations.
The problem is that your and my names are the same. No idea how to rename. So better if I or you fix zoom.

from chrome-minimal-bookmarks-tree.

Let's see what you come up with, and then we'll see how we can combine that with zoom 👍

from chrome-minimal-bookmarks-tree.

I have quickly found a solution to fix zoom. Just need to apply zoom to <ul id="bookmarks">. In addition, the scrolling button will no longer be so ugly big.

from chrome-minimal-bookmarks-tree.

Oh, that sounds like a plan. I'll try it somewhere next week 👍

from chrome-minimal-bookmarks-tree.

It becomes fixed if to just change this string:
var htmlBodyElement = document.querySelector('#bookmarks');
But it is shorter to remove that string and replace htmlBodyElement by bookmarks here:

if (zoom !== 100) {
    bookmarks.style.zoom = "".concat(zoom, "%");
}

But also need to fix that the scrolling bar slightly goes under the pop-up. It should be much harder (as the previous problem is too easy). Will try.

from chrome-minimal-bookmarks-tree.

Will try.

Thanks!

Could you please also check when you do that the popup that opens on right click opens in the right place? See #114

from chrome-minimal-bookmarks-tree.

I am not sure about the essence of #114.
It works even faster if zoom > 100 because less favicons in the pop-up. Chrome loads them too slow.

from chrome-minimal-bookmarks-tree.

About "the scrolling bar slightly goes under the pop-up" - it is if height > 595 - but I don't understand why.

from chrome-minimal-bookmarks-tree.

Then we should limit the height to 595.

from chrome-minimal-bookmarks-tree.

It is not so big problem to do that. It just eats up to 5 pixels of the scrolling button but bookmarks are well. I would like find out this.

from chrome-minimal-bookmarks-tree.

There is a big problem because dragula append temporary elements to body (not to #bookmarks). So either to set this, or to add scrolling in html (not in #wrapper).

from chrome-minimal-bookmarks-tree.

Or stop using CSS zoom, and use rem instead. Zoom makes everything too hard.

from chrome-minimal-bookmarks-tree.

I have already easily fixed the problem above.
What is rem?

from chrome-minimal-bookmarks-tree.

You fixed the current problems, but it seems zoom messes up all calculations, so there will be more. We need to get rid of it.

rem is like em, but relative to the root HTML element, instead of its parent.

from chrome-minimal-bookmarks-tree.

When we use rem the size of the popup should change with the font size the user sets in the browser. If they have bad eyes and select a bigger font size, the popup will become bigger as well.

from chrome-minimal-bookmarks-tree.

You fixed the current problems

Not all small. And can't currently fix the biggest - dragula's dragging. But it is interesting.

rem is like em

You think I know what is em? No.

from chrome-minimal-bookmarks-tree.

Lol. em is "the height of a capital M". It is a relative unit of height. If you increase the browser font size, any element with size defined in em will go bigger as well. It's like a zoom without using CSS zoom.

from chrome-minimal-bookmarks-tree.

Oh, I thought you mean some package. I remember em. But it is a not popular unit.
But anyway, you have to zoom favicons.

from chrome-minimal-bookmarks-tree.

I know. But that's possible if you scale them with background stretch I think. Will have to try that later.

from chrome-minimal-bookmarks-tree.

I've used background-size instead, and that works just fine. Zoom option is gone.

See #124

from chrome-minimal-bookmarks-tree.

But how to name my project option for small fonts when only the font size will be increased without increasing element sizes, favicons?

from chrome-minimal-bookmarks-tree.

ClearFont? ReadableFont? ScaledFont?

from chrome-minimal-bookmarks-tree.

Really. But also need to use "size" like "clear font size" or "clear font scale". Or even "unaffect font size".
You are going to implement "affect font size" which affects all elements (like zoom).
But possible to use both at the same time. Because "unaffect font size" is the ratio between the element and the font.

from chrome-minimal-bookmarks-tree.

Or you can leave the "zoom" option but implement it using font-size.

from chrome-minimal-bookmarks-tree.

Normalised font size maybe?

from chrome-minimal-bookmarks-tree.

No. not suitable. I like "unaffect font size" which doesn't affect anything else except itself.
Or you can still use the "zoom" name and my option will be "font size".

from chrome-minimal-bookmarks-tree.

If you can post your code we can see how and if it can be used in this extension.

from chrome-minimal-bookmarks-tree.

It is not ready yet. But with that, the font option will be perfect.

from chrome-minimal-bookmarks-tree.