feature request: add non standard `address` field to `EthKeyStore` about eth-keystore-rs HOT 5 CLOSED

@tmpfs @tynes quick PR for this. Let me know if this is something you'd be okay with

from eth-keystore-rs.

Hi @tynes Yes that's true geth does add an address field to the keystore, and after some conversations in the PR #8 I was requested by a user to not assume that this library will only be used for creating/encrypting/decrypting "Ethereum private keys" (@tmpfs was encrypting private key shares for an MPC construction).

But I do agree that compatibility with geth conventions might be a good-to-have for this repository.

How about I add a feature geth-compat and enable the address field when this feature is enabled? Would that be good for you @tynes ?

from eth-keystore-rs.

Ha, interesting that this come up. Rather than a geth-compat feature could we convert the extra argument to Option<KeystoreOptions> and then just do:

pub struct KeystoreOptions<'a> {
  /// File name, defaults to the UUID.
  pub name: Option<&'a str>,
  /// Public address, when available will be embedded in the keystore.
  pub address: Option<String>,
}

Does that work for you @roynalnaruto ?

from eth-keystore-rs.

From what I understood @tynes meant he would like support to read/write an address field in the JSON keystore. I think the best solution to enable that is by feature gating it as it depends on a few more dependencies which we wouldn't need if such support is not required (as in your case).

from eth-keystore-rs.

From what I understood @tynes meant he would like support to read/write an address field in the JSON keystore. I think the best solution to enable that is by feature gating it as it depends on a few more dependencies which we wouldn't need if such support is not required (as in your case).

This is definitely what I meant and I was concerned about adding new dependencies but putting it behind a feature gate solves that problem. Thank you!

from eth-keystore-rs.