Beat Saber 1.16.3 / 1.16.4 support about beatsaberserverbrowser HOT 6 CLOSED

dbb5e9a adds core support for 1.16.3 with some issues remaining:

• Lobby UI only works once, then completely breaks afterwards - possibly related to BSML - exception is tied to the left-side panel ("a type cannot be loaded") and only happens when server browser is installed (confirmed: ONLY happens if we register the lobby panel)
  • System.TypeLoadException: Could not resolve type with token 01000076 (from typeref, class/assembly MenuViewControllersInstaller, Main, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null)
  • [CRITICAL @ 11:23:47 | UnityEngine] TypeLoadException: Failure has occurred while loading a type. [CRITICAL @ 11:23:47 | UnityEngine] HMUI.ViewController.__Activate (System.Boolean addedToHierarchy, System.Boolean screenSystemEnabling) (at <b375412bba0f46b3a6766de8a90821df>:0)
• Joining a game through the server browser works, but you immediately leave the lobby - you appear for just a second to the host - could be the exception handler auto kicking? Actually really hard to debug without being able to control the host lol
• BSSB API is not made aware of who the host is because it's a dedicated server ghost now, we'd need to check the "isPartyOwner" and pass that along

from beatsaberserverbrowser.

I've opened a BSML issue for the gameplay tab problem:
monkeymanboy/BeatSaberMarkupLanguage#91

This fix is pretty simple as it turns out, added a PR:
monkeymanboy/BeatSaberMarkupLanguage#92

from beatsaberserverbrowser.

Joins are now working, but there's more:

• UI: The "connection error" dialog no longer gets dismissed properly, which causes a soft lock situation if "Retry" succeeds
• General: Party owner can transition mid-game, which means one player may take over lobby announces from another

from beatsaberserverbrowser.

There's also some weirdness when joining a game via the browser right after it's ended.

Once a server shuts down it starts issuing CFR-13's for a few minutes (Server Is Terminating).

After that period, however, the join will go through, and you'll end up in a quick play lobby alone.

• Deal with being put in the wrong lobby on join (like the old quickplay check?)

from beatsaberserverbrowser.

Some extra changes were needed for the 1.16.3 / 1.16.4, those are now done.

Quick summary of remaining tasks, for my own sanity:

• Mod side: Check party leader, add to announce message, handle host transition gracefully
• API side: Better system for allowing multiple announcers for one server
  • Quick play servers can have multiple announcers, and stay up as long as anyone is announcing
  • Custom servers should only respect/show the latest party leader's announcement

from beatsaberserverbrowser.

closing this, refer to #35

from beatsaberserverbrowser.