Master Server switching, preparation about beatsaberserverbrowser HOT 6 CLOSED

@jcoenen96 BeatTogether is probably closest to completion and it looks like they'll be ready for testing soon ("in a day or two").

from beatsaberserverbrowser.

Some quick & dirty notes on swapping master servers:

• MasterServerEndPoint is defined in NetworkConfigSO → masterServerEndPoint property. It's Harmony patchable, and when unpatched it's based on _masterServerHostName and _masterServerPort (2328).
• A potential issue is that mods will do their own patching, which means any patching we do on the server endpoint could conflict.
  • Need to find a safe way to do this where we can both read the mod's value and still override its patch if needed.
  • And/or discuss with mod devs to find some kind of universal solution to server swapping.

from beatsaberserverbrowser.

It looks like the game reads the master server endpoint whenever you try to quickplay, host or join. That's good news because we can swap it out during runtime whenever outside of a lobby and it will work.

Official endpoints seem to be steam.production.mp.beatsaber.com and oculus.production.mp.beatsaber.com.

from beatsaberserverbrowser.

109abf6 adds basic support for master server swapping. The rundown is this:

1. We detect which master server endpoint is being used, and determine whether it's official or set by a mod
2. Your last used master server is attached when your game is announced to the server browser API
3. When you join a game off the server browser, we'll override your master server or set you back to official servers as needed

I like this solution because it means even when you use a crossplay mod, you could still play a game on official servers if you want. Or even if you don't have a crossplay mod installed you may still be able to join the crossplay server this way.

A few things to check and tidy up before this is 100% ready:

• Restore the user's preferred master server after a game finishes (disable our override when you leave the game)
• API server tweaks: if a game is using a custom/crossplay server, disable platform filtering for that game
• Need to actually test with a real life custom master server mod

from beatsaberserverbrowser.

If you have already a custom master (test) server running, could you also release this one? I would love to test around with this concept a bit more.

from beatsaberserverbrowser.

This is now implemented and will ship soon 🚢

from beatsaberserverbrowser.