Comments (7)
I do agree that the word Percent
is deceptive. I think that renaming would be preferred. We can do what we did previously, which is to add the field and then make an announcement to remove the old param later?
from cr-api.
Percent being 1 or 100 is debatable — Perhaps it’s a matter of field name.
For example, if percent remains 1 without changing it to 100, in Python, I’d be able to:
cc = 1
print("{:.0%}".format(cc))
and get 100%
as output. I am sure that other languages may have shortcuts like this also. When representing percentage with max as 100 instead of 1, bugs often appear because you need to keep on remember that certain fields are x100. Happens to me often that I either forgot to multiply by 100 or doing it multiple times. With this being 1 max I keep all the values and only format it at the output stage as a format.
Alternatively maybe rename field to something like clanChestCompletion
which then you can convert to percent yourself?
from cr-api.
If you want to keep it at 1
, the word Percent
is very deceptive. Renaming it to Completion
would be good but might break some other work out there
from cr-api.
Whatever you guys like, just let me know.
As for the tier, can someone create a list of tier thresholds?
from cr-api.
Thresholds are in the wiki as linked in the first line of the issue.
from cr-api.
@selfish you can use this: https://github.com/cr-api/cr-api-data/blob/master/dst/clan_chest.json
from cr-api.
Clan chest data dropped until further notice.
from cr-api.
Related Issues (20)
- warTrophies on history is always 0 HOT 2
- % Cards level in war cvs HOT 1
- Gold chest name in player chest cycle HOT 1
- trophyChange field missing in v3 player battles endpoint HOT 3
- card levels are formatted in the old form of 13-11-8-5 instead of 13-13-13-13 HOT 2
- /player/{tags}/chests endpoint, always returns HTTP 400 HOT 1
- Multitag player battles for v3-api HOT 1
- Rarities info for v3-api HOT 1
- [V3] Clan search fails without name in query HOT 1
- Clan family change HOT 1
- Tower health left HOT 4
- Add flag for global tournament HOT 1
- Battle download on the activity log? HOT 3
- App creation HOT 2
- Add a percentage of lifetime wins in a war HOT 2
- Clan War non-members data is missing HOT 1
- Get all players
- Bug: Clan page links not working properly HOT 1
- Source for Battle Replays HOT 1
- Help HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cr-api.