Giter Club home page Giter Club logo

Comments (7)

smlbiobot avatar smlbiobot commented on July 17, 2024 1

I do agree that the word Percent is deceptive. I think that renaming would be preferred. We can do what we did previously, which is to add the field and then make an announcement to remove the old param later?

from cr-api.

smlbiobot avatar smlbiobot commented on July 17, 2024

Percent being 1 or 100 is debatable — Perhaps it’s a matter of field name.

For example, if percent remains 1 without changing it to 100, in Python, I’d be able to:

cc = 1
print("{:.0%}".format(cc))

and get 100% as output. I am sure that other languages may have shortcuts like this also. When representing percentage with max as 100 instead of 1, bugs often appear because you need to keep on remember that certain fields are x100. Happens to me often that I either forgot to multiply by 100 or doing it multiple times. With this being 1 max I keep all the values and only format it at the output stage as a format.

Alternatively maybe rename field to something like clanChestCompletion which then you can convert to percent yourself?

from cr-api.

fourjr avatar fourjr commented on July 17, 2024

If you want to keep it at 1, the word Percent is very deceptive. Renaming it to Completion would be good but might break some other work out there

from cr-api.

selfish avatar selfish commented on July 17, 2024

Whatever you guys like, just let me know.
As for the tier, can someone create a list of tier thresholds?

from cr-api.

fourjr avatar fourjr commented on July 17, 2024

Thresholds are in the wiki as linked in the first line of the issue.

from cr-api.

smlbiobot avatar smlbiobot commented on July 17, 2024

@selfish you can use this: https://github.com/cr-api/cr-api-data/blob/master/dst/clan_chest.json

from cr-api.

selfish avatar selfish commented on July 17, 2024

Clan chest data dropped until further notice.

from cr-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.