Comments (6)
Thanks, @mclearc that did the trick. I'll make a PR, since I've got it "right here".
from nano-emacs.
I'm not using helm so I'm not sure what is the problem. Starting with this configuration and if you remove anything nano related, does it work as expected? If yes, can you start adding nano files one by one to check which one is faulty?
from nano-emacs.
I found I had to add helm faces in a specific way (note the various functions) though haven't tested this lately, but you might give it a try first (put this in nano-theme.el
):
(defun nano-theme--helm ()
"Derive helm faces from nano faces."
(with-eval-after-load 'helm
(set-face 'helm-selection '(nano-face-strong nano-face-subtle))
(set-face 'helm-match 'nano-face-strong)
(set-face 'helm-source-header 'nano-face-salient)
(set-face 'helm-visible-mark 'nano-face-strong)))
(defun nano-theme--helm-swoop ()
"Derive helm faces from nano faces."
(with-eval-after-load 'helm-swoop
(set-face 'helm-swoop-target-line-face '(nano-face-strong nano-face-subtle))))
(defun nano-theme--helm-occur ()
"Derive helm faces from nano faces."
(with-eval-after-load 'helm-occur
(set-face 'helm-moccur-buffer 'nano-face-strong)))
(defun nano-theme--helm-ff ()
"Derive helm faces from nano faces."
(with-eval-after-load 'helm-ff
(set-face 'helm-ff-file 'nano-face-faded)
(set-face 'helm-ff-prefix 'nano-face-strong)
(set-face 'helm-ff-dotted-directory 'nano-face-faded)
(set-face 'helm-ff-directory 'nano-face-strong)
(set-face 'helm-ff-executable 'nano-face-popout)))
(defun nano-theme--helm-grep ()
"Derive helm faces from nano faces."
(with-eval-after-load 'helm-grep
(set-face 'helm-grep-match 'nano-face-strong)
(set-face 'helm-grep-file 'nano-face-faded)
(set-face 'helm-grep-lineno 'nano-face-faded)
(set-face 'helm-grep-finish 'nano-face-default)))
from nano-emacs.
By the way, for the mu4e customization, you don't need to use nano at all. You can only use the nano-mu4e.el
and adapt the few faces that are required (only four I think).
For the helm problem, the culprit seems to be helm-swoop, is that right? if yes, I can have a look at the code to see if I can find something strange inside.
from nano-emacs.
If I'm remembering correctly, the problem is that helm-swoop (and other parts of helm) are not all loaded when helm itself is, so the single with-eval-after-load
call isn't enough. Hence the separate loading of helm parts as described above.
from nano-emacs.
You mean the above init splitting works as intended ? If so, can you make a PR?
from nano-emacs.
Related Issues (20)
- Contrast difference for agenda tasks that are overdue and scheduled today HOT 13
- [Bug] Error "Invalid face" bookmark-menu-heading - causes ivy minibuffer on some commands to throw error (+ other packages) HOT 4
- [Bug] Org-mode headings in source code blocks override indentation and formatting from src code block HOT 4
- [Feature Request] Ability to change code syntax highlighting theme inside nano HOT 1
- Changing the default to Nano Dark? HOT 8
- Hide nano-modeline HOT 2
- Nano Writer Mode HOT 1
- frame/windows layout change when opening minibuffer
- Different `display-buffer` behaviour HOT 1
- nano-mu4e updates for newer mu? HOT 1
- No bookmark-menu-heading in Emacs 29.0.91 HOT 4
- ELPA version of nano-modeline is missing deps (nano-faces?) HOT 10
- We eagerly await evil-mode support!
- nano-modeline breaks on html files HOT 3
- Writer mode : add a custom to define the default font family HOT 2
- Wrong number of arguments HOT 2
- cursor stays visible in first window when switching to the second window HOT 2
- Add custom variables for optional packages HOT 1
- Weird emacs freezing with nano-modeline.el HOT 2
- (^^)(^^)(^^)(^^)(^^) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nano-emacs.