Please add a README explaining how to add new tests about system_tests HOT 2 CLOSED

@nuclearsandwich - thank you, this answers my questions, you can close this issue if you like.

from system_tests.

The system_tests repository is primarily meant to be internal-facing to the core team. If you're making changes to rclcpp or another repository which could benefit from additional system tests I would suggest raising the question of including additional system tests in the that pull request before opening a pull request here.

We are currently concentrating efforts on other aspects of ROS 2 development and the quasi-internal status of this repository sets it lower on the priority list of things which could use improved documentation.

If you are looking to implement additional system tests on your own you could start by using existing tests as a template.

For the rclcpp service tests this block in CMakeLists.txt adds the test executables to the build and this one adds them to the macro which invokes the test once per each rmw implementation being tested.

For this test the source for the server executable is a normal ROS 2 node providing a service while the client executable contains GTEST macros to perform tests on the service call results.

Since I've posted some information above, I'll try to reformat it to work as a minimal readme which recommends that contributors discuss new system tests in implementation pull requests before starting the pull request process here.

from system_tests.