See this latest job: <a href="http://54.183.26.131:8080/job/ros2_batch_ci_windows/199/

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

I'm not sure why I created this issue here, probably should be on <code class="notrans

master does not compile on Windows about rmw_connext HOT 3 CLOSED

ros2 commented on September 13, 2024

master does not compile on Windows

from rmw_connext.

Comments (3)

wjwwood commented on September 13, 2024

@esteve, do you have any idea about this? A naive guess is that it has something to do with the ability to pass different kinds of callbacks to the create_service method.

from rmw_connext.

esteve commented on September 13, 2024

@wjwwood this should fix it, but it's too verbose IMO:

  node->create_service<userland_msgs::AddTwoInts>(
    "service_name",
    static_cast<rclcpp::service::Service<userland_msgs::AddTwoInts>::CallbackWithHeaderType>(add));

from rmw_connext.

wjwwood commented on September 13, 2024

I'm not sure why I created this issue here, probably should be on rclcpp.

Anyways, your suggestion works, but I agree that it's too verbose:

diff --git a/userland/src/add_two_ints_server.cpp b/userland/src/add_two_ints_server.cpp
index 72a3573..377f5b8 100644
--- a/userland/src/add_two_ints_server.cpp
+++ b/userland/src/add_two_ints_server.cpp
@@ -47,7 +47,8 @@ int main(int argc, char ** argv)

   auto node = rclcpp::Node::make_shared("add_two_ints_server");

-  node->create_service<userland_msgs::AddTwoInts>("add_two_ints", add);
+  node->create_service<userland_msgs::AddTwoInts>("add_two_ints",
+    static_cast<rclcpp::service::Service<userland_msgs::AddTwoInts>::CallbackWithHeaderType>(add));

   rclcpp::spin(node);

diff --git a/userland/test/test_server.cpp b/userland/test/test_server.cpp
index 612e449..8190fdf 100644
--- a/userland/test/test_server.cpp
+++ b/userland/test/test_server.cpp
@@ -33,7 +33,8 @@ int main(int argc, char ** argv)

   auto node = rclcpp::Node::make_shared("test_server");

-  node->create_service<userland_msgs::AddTwoInts>("service_name", add);
+  node->create_service<userland_msgs::AddTwoInts>("service_name",
+    static_cast<rclcpp::service::Service<userland_msgs::AddTwoInts>::CallbackWithHeaderType>(add));

   rclcpp::spin(node);