Giter Club home page Giter Club logo

Comments (3)

baxelrod-bdai avatar baxelrod-bdai commented on June 16, 2024 6

Understood. However, SimpleActionServer already has the flexibility to allow users to do complicated things if they want by subscribing to the goal and preempt callbacks: http://wiki.ros.org/actionlib_tutorials/Tutorials/SimpleActionServer%28GoalCallbackMethod%29.

I can certainly envision some advanced behaviors that one might want when a goal must be rejected, but I think the SimpleActionServer should do something simple like preempting the current goal.

I fail to see how adding this option in any way decreases the usefulness or simplicity of SimpleActionServer.

from actionlib.

tfoote avatar tfoote commented on June 16, 2024 1

The goal of the SimpleActionServer is to provide a simple solution which covers the simple use cases only, allowing an action server to be implemented in a few lines of code. It does not try to provide full coverage of the Action state space. If you want more complicated behaviours it's recommended to create your own action server implementation.

from actionlib.

progtologist avatar progtologist commented on June 16, 2024 1

Resurrecting an old issue:
@benaxelrod actually the SimpleActionServer has very limited flexibility. If you examine closely the
template <class ActionSpec> void SimpleActionServer<ActionSpec>::goalCallback(GoalHandle goal)
function you will see that the user can only do very few things with his custom goal callback. E.g. he cannot reject it and keep executing the previous goal as it's preemption status has been altered.
As @tfoote has suggested, you must implement your own ActionServer. My only -minor- complain is that there are no other Action Servers/Clients provided besides the Simple ones.

from actionlib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.