Giter Club home page Giter Club logo

Comments (6)

T-Lemmel avatar T-Lemmel commented on June 8, 2024 3

So would '/local_costmap/local_costmap.ros__parameters.obstacle_layer.scan.topic': robot_name + '/scan', be the correct one ? It still doesn't work, I'm sorry it's probably a stupid error but can you send the full line please ?

Edit : found it, it' is :

'local_costmap.local_costmap.ros__parameters.obstacle_layer.scan.topic': '/' + robot_name + '/scan',

Thanks again for your help and everything you do for Ros in general 😄

from navigation2.

SteveMacenski avatar SteveMacenski commented on June 8, 2024

You just need to fully set the path. Either you can not set any portion of the path of a variable and change all that match or set the full path and change only the one. It does not support in between. Specify the full /local_costmap/local_costmap obstacle_layer.scan.topic or take a look at the implementation and I welcome a PR to add that feature potentially :-)

https://github.com/open-navigation/navigation2/blob/12c31c69666fc8e5642ca9db041be8f3faf47684/nav2_common/nav2_common/launch/rewritten_yaml.py#L35

from navigation2.

T-Lemmel avatar T-Lemmel commented on June 8, 2024

hooo, ok thanks 👍

I will not be able to test it until next week, i'll make sure to close the issue then if it solves the problem.
But even looking at the implementation, i don't get why it would work with other parameters such as odom_topic (see above), wouldn't i need to specify controller_server/odom_topic ?

from navigation2.

SteveMacenski avatar SteveMacenski commented on June 8, 2024

Because the leading / makes it a global match not a partial match. All your full-paths or only key variable names worked fine. The ones that didn't work are partial paths

from navigation2.

T-Lemmel avatar T-Lemmel commented on June 8, 2024

I'm sorry but i can't seem to make it work, i'm not sure of the syntaxe though, should this one work ?

image

I tried pretty much all combinations of where to place '/' & '.' but none worked

from navigation2.

SteveMacenski avatar SteveMacenski commented on June 8, 2024

Ah, I think because you missed a namespace for the absolute paths: https://github.com/ros-navigation/navigation2/blob/main/nav2_system_tests/src/system/test_system_launch.py#L63

ros__parameters exists (and is somewhat annoying)

from navigation2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.