Giter Club home page Giter Club logo

Comments (7)

zachary-foster avatar zachary-foster commented on July 29, 2024

for taxa classes we talked about using hierarchies, but for taxa classes we talked about using hierarchies, but...

I actually just addressed this in my PR before even seeing this issue

for the function taxa for taxa classes, the pkg is named taxa, so i'm using taxa_ right now

Yea, I was thinking about that too. I think the package should be renamed since taxa is such a good name for a class. The best new package name I came up with is taxar, which is OK, but not great.

One option is to simply merge binomen and taxa packages

I would be fine with that.

from taxa.

sckott avatar sckott commented on July 29, 2024

Saw the PR, thanks

I think merging into binomen is ideal, esp since there are already parsing/etc. methods for taxmap classes, and no equivalent for taxa classes. dplyr is needed for taxmap methods, and also for binomen methods, so we're not adding additional heavy dependencies

from taxa.

zachary-foster avatar zachary-foster commented on July 29, 2024

Sounds good to me

from taxa.

zachary-foster avatar zachary-foster commented on July 29, 2024

In order to maintain the issue and commit history of this repo, what do you think of merging the code of the current binomen and renaming this repo to binomen?

from taxa.

sckott avatar sckott commented on July 29, 2024

I do want to retain commit history for both - i'll google around how best to do the merge

from taxa.

zachary-foster avatar zachary-foster commented on July 29, 2024

That would be great if that is possible

from taxa.

sckott avatar sckott commented on July 29, 2024

i think we can close this now, since just porting over some verb like methods from binomen

still not sure if we need/should change taxa_ or not

from taxa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.