scp_upload > list_all fails if directory is provided - fixed code included about ssh HOT 5 CLOSED

I don't think that can be correct because file.exists() also works for directories? Can you give an example of how to reproduce the error?

from ssh.

Hi @jeroen,
Hmm, thanks for pointing this out - I figured something must be up since no one else encountered issues with this yet.
After some testing it looks like it has to do with providing a trailing slash at the end of the character input for a directory - ie:
file.exists("~/")
[1] FALSE
dir.exists("~/")
[1] TRUE

file.exists("~")
[1] TRUE
dir.exists("~")
[1] TRUE

file.exists("~/.Rprofile")
[1] TRUE
dir.exists("~/.Rprofile")
[1] FALSE

Adding the dir.exists accounts for the cases where a directory is supplied with a trailing slash.

from ssh.

Ah okay, interesting. Can you send a PR then?

from ssh.

Sure, shouldn't take long ~

from ssh.

Looks done, closing, thanks!

from ssh.