Include [beacon] in GET_PROBE_LIMITS macro about zippy-klipper_config HOT 7 CLOSED

I can give it a shot.

I don't personally own one to test with, and I don't believe it's supported natively so that may pose a problem.

I will throw something together and send it to you if you wanna test it.

My main concern is that I need to be able to query the beacon config values through the printer object.

Every native feature supports this function, but it's sometimes left out of non-native addons like this beacon config.

Give me an hour or so and I will put together an initial draft and someone who owns a beacon can give it a try.

from zippy-klipper_config.

Here's a test release

If you are able to test it out for me and it works we can push it to the main repo.

from zippy-klipper_config.

Here are the results on my Beacon equipped printer. All of the results are valid and I was able to generate a bed mesh from the minimum and maximum values. The only lingering question is the Z-Offset result. Looking at my printer.cfg, there isn't a clear indicator of a Z-offset. I think the Beacon stores it in another way than how it is traditional done.

from zippy-klipper_config.

there isn't a clear indicator of a Z-offset. I think the Beacon stores it in another way than how it is traditional done.

Ah, you are correct, I overlooked that.

Looking at the config in the docs you linked, it doesn't have a z_offset value. It also doesn't appear to need one based on what I can gather of how it works.

So I'm think I can just have it skip that line for beacon probes, does that sound good?

I'm open to pulling another value as well, maybe trigger_distance?

Let me know what you think and I will merge it in. :)

from zippy-klipper_config.

Here is a version that tries to use trigger_distance instead

from zippy-klipper_config.

Sounds good to me!

from zippy-klipper_config.

Ok great! 👍

I will push it to the repo and close this issue then.

Thanks for the suggestion! :)

from zippy-klipper_config.