Giter Club home page Giter Club logo

Comments (5)

jfinkhaeuser avatar jfinkhaeuser commented on May 30, 2024

Hmm. Thanks for this! Even with the @mention it got lost in my email, sorry about that.

Well, the idea is that we try v3 first, then try v2, and then fail as a way of detecting the version. But you're right, with an error in a v3 spec, the wrong message would be produced.

I'll produce a patch soon.

from prance.

jfinkhaeuser avatar jfinkhaeuser commented on May 30, 2024

FWIW, I'm happy to accept PRs in general. But I can probably get a fix out tomorrow.

from prance.

michalzubkowicz avatar michalzubkowicz commented on May 30, 2024

You are fast, thanks ;)

from prance.

jfinkhaeuser avatar jfinkhaeuser commented on May 30, 2024

The fix is basically done, but the builds fail for other reasons. I'll need a tad longer to get a release out. Should happen today, though!

from prance.

jfinkhaeuser avatar jfinkhaeuser commented on May 30, 2024

v0.13.0 is released.

The fallback is no longer used; instead, the major spec version is used to determine the exact validation method.

Looking at the code again, it became obvious that the fallback is from a time before we parsed and examined the spec version - so now it's useless, and as you pointed out actually confusing.

from prance.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.