Giter Club home page Giter Club logo

Comments (3)

romgain avatar romgain commented on June 13, 2024

Hi @marcospassos !

What exactly are you trying to test?

When testing connection timeouts, it's usually better to mock timers rather than artificially introduce delays, as they can make tests slow and flakey.

(For instance, jest will kill tests if they take longer than 5 seconds - that makes it impossible to test reconnection or timeout logics without mocking out the timers.)

from jest-websocket-mock.

romgain avatar romgain commented on June 13, 2024

Hi @marcospassos !

I think that a graceful solution for this could be to add a autoConnect option to WSOptions in the constructor that defaults to true.

We could then move this block to a separate connect function: https://github.com/romgain/jest-websocket-mock/blob/master/src/websocket.ts#L48-L60 , that would be called automatically when autoConnect is true.

You're use case would then be achieved like this:

const server = new WS("ws://localhost:1234", { autoConnect: false });

expect(client.readyState).toBe(WebSocket.CONNECTING);

setTimeout(() => server.connect(), 10000);

// 10 seconds later...
await server.connected;

What do you think?

Would you be open to sending a PR that adds this?

from jest-websocket-mock.

romgain avatar romgain commented on June 13, 2024

Closing for now, but feel free to reopen if you have more feedback/questions!

from jest-websocket-mock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.