Comments (4)
The following are also not supported:
{$IF SOME_CONSTANT >= SOME_INTEGER}
{$IF SOME_CONSTANT > SOME_INTEGER}
{$IF SOME_CONSTANT = SOME_INTEGER}
{$IF SOME_CONSTANT < SOME_INTEGER}
{$IF SOME_CONSTANT <= SOME_INTEGER}
(Basically, any expression other than "DEFINED" or "NOT DEFINED")
from delphiast.
Re my last comment, I suggest we make "complex Conditional Expression evaluation" a separate issue as this would be best implemented AFTER resolving issue #30.
A working solution to the original context specified in this issue has been committed to my fork, and a pull request issued. It has been tested with every combination of expression, and appears to work very well indeed.
from delphiast.
Now it's much better! But we also have to remember that brackets is also not supported yet. Like:
{$IF DEFINED(A) AND (DEFINED(B) OR DEFINED(C))}
I'll create a new issue later to better describe the current state.
from delphiast.
I did think about that before I implemented my intermediary solution.
The only thing there is I'd have to define and build an "expression tree" before evaluating it. It's not exactly the most difficult thing in the world, and I'm going to get that done hopefully this coming weekend when I have some time free.
The reason I did the intermediary solution is that certain units in a particular codebase were using multiple conditional expressions and wouldn't parse. Thus far, I haven't encountered any "conditional expression trees" in our codebase, so I didn't put the extra time in (at this point).
Beauty of outsourcing the solution into its own method (rather than all rolled into that massive CASE OF statement) is that we need only implement it once, and it applies to both {$IF} and {$ELSEIF} statements identically.
from delphiast.
Related Issues (20)
- Can't parse System.Classes.pas HOT 2
- Can't parse Posix.SysSocket.pas
- Can't parse System.Internal.Unwinder.pas
- Attributes for variant record fields missing HOT 2
- How to compile in Lazarus v2.0.6 HOT 2
- Need list of all comments HOT 10
- Need feature to REMOVE all elements of a specific type from the source HOT 1
- Get the end_line and end_col of a multi-line comment? HOT 3
- Lexer does not fully initializes its state HOT 1
- Possible string mismatch? HOT 2
- Lexer does not parse Unicode characters
- Procedure declaration with varargs directive is not fully supported
- {$I ..\file.inc} is not proceed correctly
- delphi2007 compile failed HOT 1
- Cannot parse System.SysUtils in 10.4.2 - should there be a default set of defines? HOT 7
- FreePascal demo is not working HOT 2
- Lexer failes parsing generic types with default value without spacecing inbetween
- Error when assigning a initial value to generic "global" variable in a specific way. HOT 1
- Should an empty begin/end block be classified as `ntEmptyStatement` ? HOT 1
- Bing chat claims: DelphiAST.Helpers file exist but it's not there ? What is going on ?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from delphiast.