[BUG] Document.save() does not trigger Insert event even when saving a new document about beanie HOT 8 CLOSED

Change Streams are not supported by Beanie yet. I plan to add them soon. Then, yes, I'll check if it is possible to have events based on them.

from beanie.

Hi! Can you please try using the Save event in addition to Insert in the list of events for the before_event decorator

from beanie.

@roman-right That would trigger the action, but it would also trigger the same action when saving an existing document

For my use case above, I'd only like to set created_at on insert.

In my project, I can just stick to intentionally using document.insert for new documents. But your documentation around events needs to be updated. Happy to submit a PR

However, looking at the implementation of document.update(), it creates a new _id if one is not on the object

        if self.id is not None:
            find_query: Dict[str, Any] = {"_id": self.id}
        else:
            find_query = {"_id": PydanticObjectId()}

This find_query with a new objectId will always return nothing, correct? If so, then I think we can call document.insert() if there is no _id instead of an update with upsert=True

Does that make sense? If so, happy to put a PR together

from beanie.

Hi @Russell-Pollari,

I wouldn't use the insert method for this case because, even if there is an id, it doesn't guarantee that such an object exists in the database. It could be, for example, a UUID generated by the default factory during object creation. In that case, we would have two different database operations for the same scenario. I prefer to keep it consistent. However, I think it would be nice to handle upsert events. I'm not sure how it is currently possible, but I'll think about it.

Regarding the documentation improvements - yes, sure. It would be great if you could submit a PR.

from beanie.

In that case, we would have two different database operations for the same scenario. I prefer to keep it consistent.

Fair point. I'm inclined to agree

However, I think it would be nice to handle upsert events. I'm not sure how it is currently possible, but I'll think about it.

I will too. I feel like an After Upsert event would be do-able, given the response from the db operation.

But not sure how to go about before upsert, other than first doing a query to determine if the document exists already. Which basically... makes using upsert redundant

from beanie.

@roman-right
What about moving towards MongoDB Change Streams as event triggers?

https://www.mongodb.com/docs/manual/changeStreams/

from beanie.

This issue is stale because it has been open 30 days with no activity.

from beanie.

This issue was closed because it has been stalled for 14 days with no activity.

from beanie.