Comments (3)
Hello! I'm the creator of both Foreman and Aftman. I donated Foreman to Roblox while I was employed there, and Roblox kept ownership over it due to their widespread internal use.
Aftman is a better fit for extensions that want to depend on native binaries. Some other extensions are considering adopting it as their backend for fetching binaries as well. We can fix this message, I agree that it is too aggressive.
Foreman has had an issue about process termination issues for a few months. While there isn't currently a PR opened against Foreman, a diff has been posted that's almost strictly additive.
More than just that issue, Aftman fixes a few fundamental issues with Foreman. In particular, Aftman's trust model and exact version dependencies are important for the foundation of an extension like this one to protect users from accidentally running untrusted code.
Right...
Have you made any efforts at getting this fixed in the Foreman library itself (e.g. writing a pull request to fix this issue)? Foreman is a much more widely used library, not Aftman, because it's been the library officially supported by Roblox for the past two years. Suggesting to use an entirely new library seems like an odd solution here, with big conflict of interest.
This response is inappropriate and was not warranted. When a decision is made that doesn't seem to make sense, often there is information that you hadn't considered. Being rude to maintainers is never the right call: you are getting something for free created by volunteers.
from vscode-rojo.
the main reason we put that notice there was to warn users about that bad behavior caused by Foreman
Right...
Have you made any efforts at getting this fixed in the Foreman library itself (e.g. writing a pull request to fix this issue)? Foreman is a much more widely used library, not Aftman, because it's been the library officially supported by Roblox for the past two years. Suggesting to use an entirely new library seems like an odd solution here, with big conflict of interest.
from vscode-rojo.
We can look at making the notice only appear one time on first load. I think the notice is still valuable because Foreman has a bug that makes the extension not work correctly (it doesn't terminate sub-processes correctly), and the main reason we put that notice there was to warn users about that bad behavior caused by Foreman
from vscode-rojo.
Related Issues (20)
- Should allow plugin management on unsupported systems if a custom path is specified.
- TypeError: Cannot read property 'globalState' of undefined
- Windows: "Manage it for me (Recommended)" button doesn't do anything HOT 7
- TypeError: Cannot read property 'find' of undefined HOT 1
- Falling back to installed version if Github goes down HOT 1
- Respect foreman configuration for Rojo version HOT 2
- command "Rojo: initialize" throw an error HOT 2
- Platform not supported warning under Arch linux HOT 3
- "Add support for optional paths" not supported in Project Schema HOT 1
- vs code plugin not working in version 2+ HOT 4
- Suggestion: Add mouse free project building HOT 1
- Cannot Install Rojo in a Project HOT 1
- Serving project doesn't automatically forward port in remote VSCode
- Rojo server appears to not shut down properly on MacOS when turned off through VSCode UI. HOT 3
- Renaming a file duplicates it HOT 1
- can't get *.project.json file
- Extension not recognizing that Rojo is installed with Aftman
- Roblox Studio Plugin installs to wrong path
- Allow user to disable "Use aftman instead of foreman" popup HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-rojo.