Giter Club home page Giter Club logo

Comments (9)

Lao-Ax avatar Lao-Ax commented on August 28, 2024 1

@brf153
I do have an instant ring when I make a call to anybody. I didn't test a case for incoming call. Will do later.

from rocket.chat.reactnative.

Lao-Ax avatar Lao-Ax commented on August 28, 2024 1

@GleidsonDaniel

are you talking about the music playing

I'm talking about this, you are right. When you start a call, the redux state prop named 'calling' (see /app/lib/hooks/useVideoConf/StartACallActionSheet.tsx#L45) become 'true' in some a saga. Then the Ringer component is rendered, and it starts async task.

from rocket.chat.reactnative.

brf153 avatar brf153 commented on August 28, 2024

@Lao-Ax you get a ring when someone makes a call in the room?

from rocket.chat.reactnative.

brf153 avatar brf153 commented on August 28, 2024

I don't get any

from rocket.chat.reactnative.

GleidsonDaniel avatar GleidsonDaniel commented on August 28, 2024

@Lao-Ax you get a ring when someone makes a call in the room?

@brf153 there is only a ringer when the call is direct, in group ou team rooms there is no ringer because it is not part of the planning to call several people at the same time, imagine a room with 100 people, 100 people receiving a call at the same time.

from rocket.chat.reactnative.

brf153 avatar brf153 commented on August 28, 2024

@GleidsonDaniel I believe Rocket Chat may have deprecated the feature for creating direct chats when using the open Rocket Chat server. Is there a workaround to initiate direct chats? I attempted to resolve this by cloning the server repository and concurrently running the backend and mobile repositories, but my laptop became unresponsive.

from rocket.chat.reactnative.

Lao-Ax avatar Lao-Ax commented on August 28, 2024

@brf153
Hi, you asked me:

get a ring when someone makes a call in the room

No, I don't have any. I've also tested the latest version #44: there is also no ring on an incoming call in direct messages neither in channels.

Looks like it is another issue which is worth to fix someday.

from rocket.chat.reactnative.

GleidsonDaniel avatar GleidsonDaniel commented on August 28, 2024

@Lao-Ax
A confirmation, are you talking about the music playing or the notification above within the app about an incoming call?

from rocket.chat.reactnative.

Lao-Ax avatar Lao-Ax commented on August 28, 2024

Hi! I've just tested the fix of the Ringer conponent.
I don't like to say this, but the issue wasn't fixed. The root cause of the error is still the same: the async task of starting a music could be finished a bit after when component was unmounted.

A video below (with audio) is how it looks on my device even with the fix #5453.

SVID_20240110_095809_1.mp4

from rocket.chat.reactnative.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.