image testing? about rocker HOT 7 CLOSED

Interesting. Where would we launch docker from? Travis CI? Does hub.docker.com have a CI facility?

from rocker.

Haven't been able to hack docker onto travis. AFAIK, Hub doesn't have that explicitly. Of course, the simplest thing to do would be to throw a RUN command for the tests right in at the end of the Dockerfile, then we get testing for free with the hub's autobuilds. (Would need a cleanup command after...)

btw, looks like I need to use Rscript instead of R for the above command or I get lots of failing tests, not obvious why...

from rocker.

Interesting. So this now invokes a test of each installed package?

from rocker.

Correct. Clearly we could modify it to test only packages of particular
concern, e.g. in the case of the hadleyverse. As I mention in my follow-up
comments, I'm still not sure that it's actually a good idea.

On Tue, Sep 30, 2014 at 10:38 AM, Dirk Eddelbuettel <
[email protected]> wrote:

Interesting. So this now invokes a test of each installed package?

—
Reply to this email directly or view it on GitHub
#8 (comment).

Carl Boettiger
UC Santa Cruz
http://carlboettiger.info/

from rocker.

If you are unsure about it, maybe r-base is not the best place?

It probably also comprises the most well-tested set of packages so ...

from rocker.

In general, I think writing tests into Dockerfiles is a promising
practice. I agree that these tests are unlikely to fail, as only
well-tested packages are included, which is why I started with r-base --
there is very low probability that these tests cause any problems to
downstream images. So I was partly motivated to model this as a kind of
'best-practices'

If a build fails, it doesn't really break anything. Anyone pulling from
the hub gets the last successful build. So I don't see a scenario in which
this creates a well-defined risk.

On Tue, Sep 30, 2014 at 11:07 AM, Dirk Eddelbuettel <
[email protected]> wrote:

If you are unsure about it, maybe r-base is not the best place?

It probably also comprises the most well-tested set of packages so ...

—
Reply to this email directly or view it on GitHub
#8 (comment).

Carl Boettiger
UC Santa Cruz
http://carlboettiger.info/

from rocker.

With automated build notifications on and a bit of travis testing we seem okay here for now. Running checks on the installed packages seems a bit overkill at this point so I'll close this out.

from rocker.