list of changed glyphs in font object about defcon HOT 9 CLOSED

You could subscribe to both Font.Changed and Glyph.Changed

In Glyph.Changed you just collect the names of glyphs that has changed
And in the single Font.Changed notification you perform your task only on the collected changed glyphs

from defcon.

knowing which glyph belongs to which font requires to run getParent on each glyphs which is also an extra task

Or glyph.font, it's just an attribute lookup.

from defcon.

All good points. Still if any notification fe: "Font.Changed" holds a dictionary of changed parts of its child fe: font.lib or glyphs it would be more convenient to deal with all the changes in one place and also could reduce number of tasks.

from defcon.

I can't see how this could be done without the same performance penalty as what you did yourself since notifications propagate upwards, there's one Font.Changed after each Glyph.Changed. Font.Changed notifications aren't an accumulation of multiple changes.

from defcon.

Maybe it doesn't have any effect in defcon but in usage it makes it possible to have all the information in one place. For example instead of adding multiple observers, one observer provides all the info about which part was changed. Then user could choose which part to deal with. Doesn't it make the code cleaner?

from defcon.

I also found another issue with the order of notifications in the first scenario. I realized that 'Font.Changed' posts first so if a glyph has been changed and I want to collect it through 'Glyph.Changed' and my task is executed in the 'Font.Changed', then no glyphs are collected and no task will be performed since 'Font.Changed' was posted first then the glyph was collected after in the 'Glyph.Changed'. I added the observers in different order but result was same.

from defcon.

Ok I realized that my algorithm was written before I knew how things work in defcon. Now I do only glyph related tasks in 'Glyph.Changed' and do the major task that could be heavy after 'Font.Changed' was posted and it works well. Thanks and sorry for the inconvenience.

from defcon.

Forgot to add this. 'Font.Changed' will be posted before the 'Glyph.Changed' so anyway the major task also has to be done inside the 'Glyph.Changed'. I hold off the heavy task by checking if the glyph is used as component in other glyphs then when all of them posted their notifications I perform the task. So using 'Font.Changed' in this case is not good way of making things faster.

from defcon.

'Font.Changed' will be posted before the 'Glyph.Changed'

That's odd, normally notifications propagate upwards, i.e. Contour -> Glyph -> Layer -> LayerSet -> Font

from defcon.