Comments (2)
The size is checked in the debug mode
Lines 135 to 136 in b37aa69
Since pybind is built in the release mode, it bypasses the check.
@jwnimmer-tri I can activate the check in the release mode. But what would be our general strategy? It is quite hard for python users to switch to debug mode, so shall we prefer DRAKE_DEMAND to DRAKE_ASSERT in our C++ code?
from drake.
See #7827. The functions DRAKE_DEMAND
and DRAKE_ASSERT
are only appropriate for Drake checking its own internal invariants. User input should always be checked with DRAKE_THROW_UNLESS
(or something similar, like an if
-test with a throw
statement).
Ideally, any patches to this function would also change it obey https://drake.mit.edu/styleguide/cppguide.html#Inline_Functions, but if this an emergency maybe the platform reviewer will let you get away without doing that part.
from drake.
Related Issues (20)
- Jupyter tests fail on Mac Ventura CI HOT 6
- Solving GcsTrajectoryOptimization with Minimum Duration Zero Leads to Cryptic Bug HOT 1
- Evaluating constraints in `IpoptSolver_NLP` is always done in series, even when the constraints could be evaluated concurrently. HOT 4
- Add a constructor to `DirectCollocation` and `DirectTranscription` that does not call `System<double>::ToAutoDiffXd(.)` HOT 2
- Add an option to require the input of `PassThrough` system
- CalcSpatialInertia(TriangleSurfaceMesh) geometry has a nonsensical default density
- Docker release v1.31.0 HOT 1
- Benchmarking infrastructure fails on Linux VM HOT 1
- [geometry] Tracking for CompliantCompliant intersection benchmark and algorithm changes. HOT 1
- Add support for other scalar types for missing `math` python bindings HOT 1
- HPolyhedron::MaximumVolumeInscribedEllipsoid() terminates program when applied to small polyhedra HOT 6
- Upgrade Externals August 2024 HOT 1
- Group documentation for bias acceleration
- August 2024 Monthly Jenkins update HOT 1
- [meshcat] Objects with paths prefixed by `/drake/illustration` aren't set HOT 2
- AttributeError: module 'drake' has no attribute 'experimental_lcmt_deformable_tri' HOT 3
- [RgbdSensor] `X_PB_` is not externally accessible HOT 1
- Easy Way to Force a Solver to Use a Single Thread HOT 8
- Add PSD constraint using Burer-Monteiro formulation HOT 3
- MultibodyPlant::SetFreeBodyPose() documentation is misleading HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drake.