Setter for Value property in FloatReference about unite2017 HOT 3 OPEN

On second thought, maybe instead we don't allow Variable.Value to get modified via the Value property, forcing users to modify the value via a FloatVariable.
This will allow other scripts that use the FloatVariable to see the changes.

The property can be changed to this:

public float Value
{
    get { return UseConstant ? ConstantValue : Variable.Value; }
    set
    {
        if (!UseConstant)
            // maybe Debug.LogError here to warn devs?
        else
            ConstantValue = value;
    }
}

from unite2017.

Sorry, I'm not the maintainer; but I got a notification, and it occurred to me to mention that I also extended the solution in this repo with differentiated read-only and writeable classes, and a lot of other features. :) If you want, you can look into it as a possible implementation.

For example this is a writeable float property, which extends the basic concrete read-only class, which is further derived from a generic abstract base class GameProperty<T> that exposes a protected setter method which takes care of propagating the changed value to subscribers:

https://github.com/baratgabor/Unity3D-ReactiveScriptables/blob/master/ScriptableObjects/Properties/FloatProperty_Writeable.cs

I also ended up differentiating 'properties' and 'events', because in my use I realized that a lot of times all I want is to push a notification to a component with a certain payload, without having an initial value set. But possibly there were other reasons too; I can't quite remember because it was ages ago. :)

from unite2017.

@baratgabor I see. I do think that creating separate read-only and writeable classes is a good solution because you have a choice on whether modifications are allowed. Thanks for showing me!

from unite2017.