File upload, how to better implement it? about next-gravity-forms HOT 7 OPEN

@robmarshall do you have any input on above questions?

from next-gravity-forms.

Nice one digging into this @Gytjarek

How can we ensure it is required to be installed

We can't. As we are not creating a WordPress side plugin we cannot show any notifications on the admin side.

There is a chance we would be able to check for the existance of a dedicated WpGraphQL Upload field. If there isnt one throw an error.
But tbh I am most inclined to have details of this in the Readme and leave it at that.

Tries to upload unsupported type

What happens if a user has added custom support for a file in WP. Such as SVG support, do they also have to handle this within this package?

Maybe we fall back to default WordPress types and show an error as you suggest, and allow this to be overridden by custom types. Purely file extension checking - nothing fancier otherwise it gets a bit scope creepy.

Multi-file upload

Thoughts on getting a single file upload working first? Reduce the workload, focus on initial feature and then extend to multi-file later.

from next-gravity-forms.

Nice one digging into this @Gytjarek

How can we ensure it is required to be installed

We can't. As we are not creating a WordPress side plugin we cannot show any notifications on the admin side.

There is a chance we would be able to check for the existance of a dedicated WpGraphQL Upload field. If there isnt one throw an error. But tbh I am most inclined to have details of this in the Readme and leave it at that.

Tries to upload unsupported type

What happens if a user has added custom support for a file in WP. Such as SVG support, do they also have to handle this within this package?

Maybe we fall back to default WordPress types and show an error as you suggest, and allow this to be overridden by custom types. Purely file extension checking - nothing fancier otherwise it gets a bit scope creepy.

Multi-file upload

Thoughts on getting a single file upload working first? Reduce the workload, focus on initial feature and then extend to multi-file later.

yes thanks for your inputs. I've implemented a single file upload already, that's why asking about Multi-file upload :)

from next-gravity-forms.

yes thanks for your inputs. I've implemented a single file upload already, that's why asking about Multi-file upload :)

Hi @Gytjarek, can you share how you implemented single file upload?

from next-gravity-forms.

yes thanks for your inputs. I've implemented a single file upload already, that's why asking about Multi-file upload :)

Hi @Gytjarek, can you share how you implemented single file upload?

Hi! Pls check it here: https://github.com/Hike-Digital/next-gravity-forms/tree/feature/fileupload, it’s a branch we’re going to merge soon

from next-gravity-forms.

yes thanks for your inputs. I've implemented a single file upload already, that's why asking about Multi-file upload :)

Hi @Gytjarek, can you share how you implemented single file upload?

Hi! Pls check it here: https://github.com/Hike-Digital/next-gravity-forms/tree/feature/fileupload, it’s a branch we’re going to merge soon

@Gytjarek Great! Thank you.

from next-gravity-forms.

@Gytjarek Is there a way to switch to the fileupload branch in your fork so I can test?

from next-gravity-forms.