inclusion into geany-themes ? about base16-geany HOT 11 OPEN

Never considered, no. Definitely not opposed to the idea. Do you think it needs a bit more testing before its inclusion?

from base16-geany.

The theme maintainer recommends the following:
"You should check out what the scheme looks like in a few different language styles. For example, C++, Python, and XML. Using one statically typed, one dynamically typed, and one tag/structured markup language [..]"

If you take http://svn.emelfm2.net/trunk/src/e2_filelist.c , notice how much yellow bold there is in the document (using the latest base16 dark theme). I have little experience with this filetype, but as per my tastes I'd remove the bold here. What do you think?

If you take a ruby file: https://github.com/chriskempson/base16-builder/raw/master/base16 , then I notice similar bold issue with both yellow and blue. Again, should we remove these?

Python: https://github.com/landroni/pLyX/raw/master/scripts/pLyX.py . I'm actually not quite sure how it should look like. At the very least, on line 9 this looks weird: re.compile. The first bit is bold yellow, and the 2nd bit is of a greyish hue. And shouldn't '''Send a help message to a yellow note in LyX.''' be of color green?

XML: http://msdn.microsoft.com/en-us/library/ms762271(v=vs.85).aspx . Looks fine, but for the out-of-tune ?> on the 1st line.

I can provide the fixes to the templates, but let me know what direction we should take.

from base16-geany.

I made a small tweak on my fork: landroni/base16-builder@7e56405

This ensures that for R files both 'asdf' and "asdf" strings have the same color (as in RStudio). I'll wait to see if there are other issues to fix before making a PR.

from base16-geany.

Also: landroni/base16-builder@ca75cda

Avoids a formatting glitch in R files with keywords like parallel or acme. Again improves compatibility with RStudio.

from base16-geany.

I made yet another minor tweak: landroni/base16-builder@4b25ea2

Now secondary keywords are properly highlighted.

I think I have sufficient (minor) fixes to make another PR upstream. Are you OK with the changes?

from base16-geany.

I went ahead with the PR: https://github.com/chriskempson/base16-builder/pull/155

from base16-geany.

Awesome! Thanks so much for pushing this forwards. Makes Geany so much better.

from base16-geany.

Thanks. :) I made yet another PR addressing most of the issues that I've pointed out above for *.py , *.c , and *.xml files: https://github.com/chriskempson/base16-builder/pull/157. This time I modeled the tweaks based on the Default theme in Geany.

Once this PR is merged, I think we can regenerate the base16-geany and then propose that for inclusion in https://github.com/codebrainz/geany-themes.

from base16-geany.

Now this latest PR has been merged. Could you update the outputed themes in base16-geany, so that we could subsequently propose them for inclusion into geany-themes?

from base16-geany.

44d9e2e

Also added a Makefile to ease the building process. Thanks so much!

from base16-geany.

Cool! I'm leaving this open until we hear from the geany-themes maintainer.

from base16-geany.