Comments (4)
Does this capability also apply to all dependencies? If a dependency isn't in a clean state then it's even worse than the main repo because it's out of sight and harder to detect.
from glock.
Yeah, I meant dependencies, not the main repo. (Frequently the main repo is dirty with in-progress changes)
from glock.
It makes sense for glock
to do that. It would be inaccurate to save a dependency as a given revision when it has a dirty working tree - resulting in a non-reproducible build for others being potentially pushed.
It's basically the equivalent of using gostatus in the following way:
# Legend:
# b - Non-master branch checked out
# * - Uncommited changes in working dir
# Show status of all dependencies (recursive) of package in cur working dir.
go list -f '{{join .Deps "\n"}}' . | gostatus --all
And making sure none of the dependencies have b
(non-master branch checked out) or *
(dirty working tree) status.
gostatus
uses this vcs
package to figure that out.
Also, FWIW, godep
already had this functionality - it wouldn't let you do godep save --copy=false
if one of the dependencies had a dirty working tree.
from glock.
Very cool, thanks for the links
from glock.
Related Issues (20)
- Speed up glock sync HOT 1
- Aliasing imports. HOT 4
- Support dependencies that aren't working directories (or clones) HOT 2
- Cosmetic inquiry: GLOCKFILE naming HOT 3
- support for single repository layouts HOT 3
- Outdated reference to godep -save=false in README.md / Overview HOT 1
- Add post-rewrite hook HOT 3
- "glock save" extremely slow on vanity import paths HOT 2
- Support for Mercurial, Bazaar, Subversion is incomplete and undocumented HOT 1
- sync occasionally fails with a "cannot find package" error HOT 6
- Consider adding GO15VENDOREXPERIMENT support HOT 11
- `glock save` gets confused by build tags HOT 1
- `glock sync` from inside git-hook can fail due to git env vars HOT 3
- glock: command not found HOT 8
- Unable to install glock HOT 12
- Dependency Issue With googlemaps.github.io/maps
- Doesn't work offline
- Please add a LICENSE file HOT 1
- `glock save` broken by #33
- Glock sync fails when checking out refs that only exist on certain tags
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glock.