Giter Club home page Giter Club logo

Comments (3)

austinov avatar austinov commented on August 25, 2024

Excuse me, it was fixed in master, but not in gopkg.in/robfig/cron.v2.
Would you fix it in gopkg.in/robfig/cron.v2?

from cron.

robbbsen avatar robbbsen commented on August 25, 2024

For me this is a downgrade of functionality. Think about I would like to update all of my jobs. I would've picked something like this:

var cronGlobal *cron.Cron

func refresh() {
	newCron := cron.New()
	// I would've started the new one first to ensure no interval gets missed
	newCron.Start()
	
	// Then I would've stopped the old one
	cronGlobal.Stop()
	
	// I could've added the jobs afterwards
	for _, job := range dbEntries {
		newCron.Add(job.Expression, job)
	}
	
	// Then I would've overwritten the global one
	cronGlobal = newCron
}

This way I could've been sure no interval gets missed while I'm setting up the new list. Because some of the items that are getting added to the new cron object are old ones from the previous cron object.

I hope it's clear what I'm talking about. Hope to find some other safe way.

from cron.

robfig avatar robfig commented on August 25, 2024

I agree that it is a bug. v3 branch has this fix, and it has other fixes too. I recommend upgrading to it.

from cron.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.