Describe the bug I try to add multiple actions in one section in j

No support for multiple values in jail.local ini file about ansible-role-fail2ban HOT 1 OPEN

robertdebock commented on May 30, 2024

No support for multiple values in jail.local ini file

from ansible-role-fail2ban.

Comments (1)

roumano commented on May 30, 2024

I confirm i get similar issue.

I don't think it's possible to fix this issue with the actual module (ini_file)

I've remove the actual ini_file tasks

- name: Configure jail.local
  community.general.ini_file:
  ...

and replace by a template tasks :

- name: Configure jail.local
  ansible.builtin.template:
    src: jail.local.j2
    dest: /etc/fail2ban/jail.local
    mode: "0640"
  notify:
    - Restart fail2ban

Of course, it's need to create the template file templates/jail.local.j2 :

{# Template to create the jail #}
{% for i in fail2ban_jail_configuration %}
[{{ i.name }}]
{% for k in i if k != 'name' %}
{{ k }} = {{ i[k] }}
{% endfor %}
{% endfor %}

And the configuration change also, please found a exemple :

fail2ban_jail_configuration:
  - name: DEFAULT
    ignoreself: 'true'
    destemail: [email protected]
    sender: root@{{ inventory_hostname }}.YYY.ZZ
  - name: guacamole
    enabled: 'true'
    port: 8080
    logpath: /var/log/tomcat9/catalina.out
    filter: guacamole_XXXX
    banaction: iptables-multiport
    maxretry: 2
    bantime: 1m
    findtime: 60m
    action: |
      iptables-guacamole[name="guacamole", port="8080", protocol="tcp"]
               smtp.py[host="smtp.XXX.YY:25", sender="[email protected]", dest="[email protected],[email protected]"]

i removed the tasks assert | Test fail2ban_jail_configuration (in assert.yml ) as the fail2ban_jail_configuration changed but ideally, it's should also be rewriten.

If you think it's the good way for fixing the issue, i can create a PR with these change.

from ansible-role-fail2ban.

Recommend Projects