Comments (11)
futhermore, the LSMinimumSystemVersion key to indicate the required minimum OS version is missing
from seashore.
The codebase contains a lot of deprecated code. I’ve been working on getting the app to be published on the App Store as well, so have been updating the code where necessary. The App Store requires the icons to be done differently so it touches the plist.
Feel free to submit a PR for the changes.
from seashore.
@core-code also, I’m nottraditionally a Mac developer so it would be nice to know similar issues you think that need to be addressed. I’m more concerned about really only things that have been deprecated because things start to break, like the color sync api.
from seashore.
@core-code not sure why the min says version is not picked up from the build settings. In most cases it should be 10.7 but I suspect it is really 10.12 due to api usage in some functions.
from seashore.
hey robert. currently quite busy but i'll try to look into this in the next few days ;)
from seashore.
fixed in 2.1.4
from seashore.
thanks i can confirm the info.plist problems have been fixed in 2.1.4
about the LSMinimumSystemVersion. previously that was a big headache because Xcode wouldn't tell you when you are using APIs that aren't available on the deployment SDK. however, that has been solved a few years back by Xcode 8 (if i remember correctly). however, i tried out compiling seashore, and when i deliberately introduced a 10.13+ API call, i didn't get any additional warnings. which is quite weird, and i wasn't able to pinpoint the cause for this. so, its hard to know if there are 10.12 calls here, without the warning working. there is definitely a lot of cruft and old stuff in there. i'd also recommend not specifying your 'development team' right in the Xcode project as this will lead to compiler errors for anyone who isn't part of your team. you can migrate this to an additional file e.g.
Seashore.xcconfig
which is empty in the git checkout but you can write your team into your copy of the file
DEVELOPMENT_TEAM = YOURIDENTIFIER
from seashore.
@core-code thanks
from seashore.
@core-code don’t I need to select that config file for each build configuration ? Or is the project name one used always? I’m working on getting it deplorable to the App Store and it is much harder to do this after the fact.... but a lot I think is due to the somewhat strange structure originally - not sure I would of used all of the plugin projects but rather some sort of build script so it could be changed in one place - but is seems that is what the build config files are for.
from seashore.
don’t I need to select that config file for each build configuration ?
i can't tell you that because i only ever use projects with a single .xcodeproj file
i suspect though that a single file linked in the main Seashore.xcodeproj is good enough
in any case, unless there are other people interested in contributing and hindered by this issue, it may not be worth putting much time into that at this point
but a lot I think is due to the somewhat strange structure originally
i've also wondered why this needs to be so complex. maybe there are valid reasons, maybe it could be done a lot simpler.
from seashore.
@core-code I've cleaned it up a lot - I think the original design was that people were supposed to be able to create their own plugins - but there was never a "plugin framework" they could link against so the code was duplicated in every plugin - so I fixed that.
anyway, thanks for your help, I am hoping to button this up today
from seashore.
Related Issues (20)
- Toggle info/alert button next to layers HOT 1
- add ability to input a 'glyph' in the text tool HOT 2
- support transparency for JPG images HOT 1
- support rich text in text tool HOT 1
- Resizing image causes wavy lines HOT 7
- support full gimp markup in text tool
- Magic Wand HOT 5
- No buttons to add text as a layer or merge with layer HOT 4
- bucket does not respect selection in 3.26 HOT 7
- pasting formatted text in text tool shows very small HOT 1
- Quitting when I want to fill in any objects HOT 3
- Turn off Layers HOT 2
- save view layers and options panels settings HOT 5
- problem dragging crop selection area HOT 1
- Modify right mouse button to draw bg color instead of erasing HOT 11
- no colours HOT 1
- Mac OS HOT 2
- Add drop shadow effect HOT 1
- Layer editing issues HOT 7
- support for webm export HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from seashore.