Call to a member function getClassAnnotations() on array with doctrine/orm:^2.12 about psr-container-doctrine HOT 10 CLOSED

@derrabus kindly fixed my sh*t in the latest release, which he is going to tag as 2.12.1 very soon; this can be closed :)

from psr-container-doctrine.

@Ocramius @eichie FYI, We are discussing potential solutions for the same problem in the Laminas Module:
doctrine/DoctrineModule#774
doctrine/DoctrineModule#775
doctrine/DoctrineModule#776

from psr-container-doctrine.

Seems like an upstream BC break: doctrine/orm#9668

/cc @greg0ire

I think a revert in upstream is kinda needed here.

from psr-container-doctrine.

@ppaulis I think this needs a full revert in upstream.

from psr-container-doctrine.

😟 @Ocramius do you foresee more breakage in other packages or do you think none of the solutions above are acceptable? Regardless of whether this gets revert, should the code in doctrine module be reworked? It seems wrong to assume every child class of AnnotationDriver will have a constructor with the same signature.

from psr-container-doctrine.

It is what it is, @greg0ire: involuntary BC breaks are bugs, and the source/root cause here is doctrine/orm.

Remember that you are only observing the BC breaks on these packages, not what users are doing in closed source software.

from psr-container-doctrine.

As for assumptions: absolutely - these modules are janky integration code, and rework may be needed overall, but that comes by including better static analysis, which would have caught this too.

These packages are old and stable though, so any change introduces risk, rather than value.

from psr-container-doctrine.

Ok, l should be able to work on this soon. I'll revert then work on trying to find a better upgrade path.

from psr-container-doctrine.

@eichie Can you please check if ORM 2.12.1 fixes your issue?

from psr-container-doctrine.

@derrabus @Ocramius @greg0ire Yes, with version 2.12.1 it works fine again. 👍

Thank You! :-)

from psr-container-doctrine.