Incompatibility with diff-hl and making olivetti a global mode about olivetti HOT 10 CLOSED

Okay, thanks. I was confused by the straight.el stuff, and thought that was downloading your config.

I'm able to reproduce it now. This is only when using the globalized mode and along with diff-hl mode. This being a user-defined globalized mode not working properly with another (not built-in) package, I don't think this is an olivetti bug.

I'll try to debug this a little, but I'm guessing that an eventual fix will be in the globalized mode.

from olivetti.

Sorry, obviously I'm lagging behind here. Glad to see you got it sorted. Thanks @larstvei :)

from olivetti.

Please attempt to reproduce this with emacs -Q and M-x load-file RET [PATH TO FILE]

from olivetti.

Do you mean something like this?

M-x load-file RET diff-hl.el RET
M-x load-file RET olivetti.el RET
M-x eval-expression RET (global-diff-hl-mode)
                        (define-globalized-minor-mode global-olivetti-mode
                          nil (lambda ()
                                (pcase major-mode
                                  ('minibuffer-inactive-mode)
                                  ('exwm-mode)
                                  ('mu4e-headers-mode)
                                  ('pdf-view-mode)
                                  ('image-mode)
                                  (_ (olivetti-mode 1)))))
                        (global-olivetti-mode 1)
M-x eval-expression RET (find-file "/file/under/git/vc")
M-x eval-expression RET (insert "test")
M-x save-buffer RET

from olivetti.

from olivetti.

Hi!

I use diff-hl and tried your globalized mode, and don't experience the problems you report.

However, I did experience similar issues when using git-gutter-fringe, which is a diff-hl equivalent I used before. diff-hl resolved it for me though. It is not particularly surprising if there are incompatibilities between packages that "mess with" the margins of the buffer.

Because I'm not able to reproduce it with the same combination of packages, there are a couple of things you could try. See if there is any additional package or configuration that might be the culprit; you can check this by starting Emacs with emacs -Q as @rnkn suggests (which inhibits your emacs config file to be loaded), and then follow the steps you suggested yourself @walseb. If the error persists, then make sure you have updated versions of both packages. Maybe check if you are using the melpa stable version of olivetti (I would suggest trying the non-stable).

from olivetti.

@rnkn No additional code at all? Because then it's not possible, it only happens when I define a globalized-minor-mode for it. I am running all the code above in a emacs -Q instance without any code not mentioned here if that's what you mean.

@larstvei Yeah, that's what I'm doing. I just run emacs -Q -l configIProvidedAbove.el. I'm using the latest version of olivetti published yesterday (fa9757f) and the latest version of diff-hl (a625033)

I'm running GNU Emacs 26.3 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.10). And actually it appears as if the bug only happens after saving and editing for the second time. I'm not sure if that's due to the latest commits, but it does happen consistently using the config above on my pc with emacs -Q.

from olivetti.

I just added some debugging prints in the lambda, checking what major modes and buffers were invoked. Turnes out diff-hl creates a buffer, which causes problems.

Does this fix your issue?

(define-globalized-minor-mode global-olivetti-mode
  nil (lambda ()
        (unless (string= " *diff-hl* " (buffer-name (current-buffer)))
          (pcase major-mode
            ('minibuffer-inactive-mode)
            ('exwm-mode)
            ('mu4e-headers-mode)
            ('pdf-view-mode)
            ('image-mode)
            (_ (olivetti-mode 1))))))

from olivetti.

Yeah that works, thanks a lot!

from olivetti.

from olivetti.