UI and data can get out of sync about knockout-sortable HOT 7 CLOSED

Initial nodes of the first table:

childNodes: NodeList[9]
0: Text
1: HTMLDivElement
2: Text
3: Text
4: HTMLDivElement
5: Text
6: Text
7: HTMLDivElement
8: Text
length: 9

Nodes after doing steps 2 and 3 above:

childNodes: NodeList[9]
0: Text
1: Text
2: Text
3: HTMLDivElement
4: HTMLDivElement
5: HTMLDivElement
6: Text
7: Text
8: Text
length: 9

So now the foreach code thinks that all three divs are part of item 2 (Ted).

As an even more dramatic example of the problem, if you now move Ted to another table, Bobby and Jim will disappear.

from knockout-sortable.

@mbest - Thanks for reporting this here. Am going to look into this one a bit more, as I am sure that Bobby and Jim's parents would be concerned if they were to disappear from class.

I see in the original sortableList binding from the other thread that a solution that worked was to clear out the list and replace it completely with the updated version. Was hoping not to re-render everything on each drop. Will research it further.

from knockout-sortable.

The other solution that should work is to make sure that the template has only a single element (or not more than two).

from knockout-sortable.

Here's an update to the fiddle showing that the problem goes away if the templates don't have the enclosing text nodes.

from knockout-sortable.

Thanks. I have suggested that to a couple of people already for the time being and it works well. When I get a chance I want to look into stripping empty text nodes that come before/after the template. I don't want the binding to be too invasive though.

from knockout-sortable.

I put in a change to strip top-level text nodes. I think that it is reasonable to expect that items will be placed in a container element. This won't help named templates. I am less eager to do named template re-writing in the binding. I am playing with some other options, but I don't want to go so far as to create a templateSource that does the stripping and a templateEngine that uses that source as part of the binding.

from knockout-sortable.

Not planning to address this any further at the moment.

from knockout-sortable.