Comments (6)
Thanks for this. I'll look at merging it in tonight with hopefully some tests to go with it.
from knockout-sortable.
@nezda In this case that there is a sub-option defined at the global level and also in the binding (same option), I think that we would want the one in the binding to win. Do you agree? Thanks.
from knockout-sortable.
I definitely agree. Unless I made a mistake, this patch should do that.
from knockout-sortable.
@nezda - this line: ko.utils.extend(value.options, ko.bindingHandlers.sortable.options);
will overwrite existing options passed into the binding with the global options. So, the result will be merged, but options specified both in the binding and globally will end up being taken from the global setting.
We would probably need to create a copy of the global options using extend, then apply the local settings to it, then replace the local settings with this new merged copy.
from knockout-sortable.
Yikes, you are right, that code didn't do exactly what I intended. I agree with your proposed solution. I will revise my copy and submit another pull request.
from knockout-sortable.
@nezda Thanks again for reporting this one and submitting the pull request. I made the fix using logic similar to what we discussed.
from knockout-sortable.
Related Issues (20)
- observableArray extended with deferred: true removes items from list HOT 2
- Draggable Incorrectly calls template init/update
- Using droppable next to a sortable
- Draggable Droppable Issue
- sortable dissapears after first drop HOT 4
- knockout-sortable not re-rendering when dragging to same index
- Sortable not working with latest jquery HOT 3
- Input and textarea cannot be selected in Firefox 40
- sortable behaviour inconsistent with droppable/draggable
- Confirmation popup before aftermove is executed HOT 1
- Sortable not working after upgrading to knockout 3.5 HOT 10
- anonymous templates will break in next version of knockout HOT 3
- droppable options drop event issue
- Does not work with knockout 3.5.0 HOT 2
- Problem after upgrading ko to 3.5.1 HOT 3
- Nested sortable support
- knockout-sortable drag and drop not working in Windows touch devices
- Get an error after clean data HOT 3
- JS error introduced by v1.2.1 "Fixed draggable and droppable disposal" HOT 1
- disableSelection on sortable
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from knockout-sortable.