Comments (5)
You can't make a branch on the main project repo. You have to fork the project first, make your branch there (or not), and then submit the PR from your fork. I believe once the PR is submitted you can also delete your fork unless you want to keep it around.
from posh-acme.deploy.
Ok, will go that route next time. =)
Thanks!
from posh-acme.deploy.
Hey @inzi, thanks for the great idea! I tweaked your implementation just a bit so that -HostHeader
accepts a string array instead of a single string which shouldn't be a breaking change. It makes things slightly easier by avoiding the string splitting. I also moved the code that removes old certs out of the host header loop so it doesn't try to delete the same old cert multiple times. I should have the changes committed to main shortly.
P.S. For future reference, there's no contributor role that you need to be a part of in order to submit a PR. From what I understand, you automatically get labeled as a contributor the first time a PR is merged into the code base.
from posh-acme.deploy.
Hi Rmbolger, I was unable to make a new branch to do a PR from.
Maybe I just need to revisit how to do a PR without a branch in github.
from posh-acme.deploy.
This is now live in 1.6.0
from posh-acme.deploy.
Related Issues (20)
- New-ItemProperty and Set-IISCertificate remote script issue HOT 8
- RDS Certificate needs NETWORK SERVICE permissions HOT 10
- Allow install cert by pfx file only HOT 6
- Trying to fix "The WebAdministration module is required to use this function" on Server 2016 HOT 3
- Need some help on creating a renewal script that renews wildcard certificates bound to multiple websites HOT 6
- Executing remote commands using Invoke-Command or Enter-PSSession produces errors HOT 1
- Guide for Exchange HOT 4
- Support for newer Powershell core versions HOT 9
- Set-IISCertificate issue with multiple sites, Server Name Identification (SNI) HOT 4
- Allow for multiple policies and/or wildcards with Set-NPSCertificate HOT 7
- Installing cert on IIS -> getting error: A specified logon session does not exist. It may already have been terminated HOT 7
- Dependency issue HOT 1
- Set-IISCertificate - RequireSNI Switch Refactor HOT 7
- Set-IISCertificate Shall Update Existing Binding on Port 443 Instead of Creating A New One HOT 1
- WSMAN RDP HOT 5
- Consider task creation HOT 2
- Dev install module path HOT 6
- Set-IISCertificate doesn't work with Site names that have some uncommon characters. HOT 2
- IIS Binding Help HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from posh-acme.deploy.