V1.9.1 is completely broken about laravel-js-localization HOT 8 OPEN

@SanderSander just a while ago I've created a comment addressing the problem #170 (comment)

The problem is disappearing slash /.
The version should be removed as soon as possible.

from laravel-js-localization.

@rmariuzzo
Thank you very much for your fast response :)

I suppose you should give the version a different tag on packagist, to ensure people re-download this patched version.

Over all, this is a feature addition, so shouldn't it be updated on the 2nd digit (1.10/1.10.0), not the 3rd (1.9.1)? Generally most packages reserve 3rd digit for patches.

from laravel-js-localization.

@rmariuzzo Thank you very much for your fast response :)

I suppose you should give the version a different tag on packagist, to ensure people re-download this patched version.

Over all, this is a feature addition, so shouldn't it be updated on the 2nd digit (1.10/1.10.0), not the 3rd (1.9.1)? Generally most packages reserve 3rd digit for patches.

I made the same suggestion for versioning in the PR :)

from laravel-js-localization.

I apologize, will try to remove the version ASAP. 😞

from laravel-js-localization.

#172 I made a PR that fixes the problem

from laravel-js-localization.

I removed the broken version from Packagist, I think that should help for now: https://packagist.org/packages/mariuzzo/laravel-js-localization

from laravel-js-localization.

#172 I made a PR that fixes the problem

I review your PR, looks fine to me. @SanderSander and @Chomiciak can you check the PR too? 🙇

from laravel-js-localization.

Thank you both for your good advices. I appreciate it.

from laravel-js-localization.