Comments (8)
Yeah the hidden dependency on vimp for mappings isn't great, I do plan on cleaning that up. Thanks for the submission @akinsho always a pleasure to have you around
I've only seen that error you mentioned when it fails to create the new window, it's then trying to position the cursor on a window it was ultimately unable to create.
I can fix the error up by not trying to use the new_window value if it doesn't exist but the root of the issue of it being unable to create the window (assumed) is still unknown to me
from goto-preview.
@rmagatti I wonder if it might be due to how I've tried to work around the mapping issue since I can't see any other way to access this plugins functions without using vimp which I haven't/would rather not install lsp_request
function at this point causes some weird issue.
use {
"rmagatti/goto-preview",
config = function()
local preview = require("goto-preview")
preview.setup {}
-- home grown copy of functionality from vimp etc.
as.nnoremap("gpd", preview.lsp_request(true))
end
}
from goto-preview.
In terms of what else I see, it seems to cause a buffer to be created with the name of the file appended with some characters.
from goto-preview.
Hey @akinsho the PR should address the mapping issues.
from goto-preview.
In terms of what else I see, it seems to cause a buffer to be created with the name of the file appended with some characters.
Now this one I'm not really sure what it is. Mind trying out the new mapping and letting me know if this new weirdly named buffer still happens?
from goto-preview.
@rmagatti I just tried the PR which is helpful thanks, I'm still seeing the bug though so I'm trying to whittle it down to a minimal init.lua and see what might be triggering it
from goto-preview.
@rmagatti done a bit of debugging with quite a minimal init.lua and it seems the underlying error I'm seeing is Error executing vim.schedule lua callback: ...site/pack/packer/start/goto-preview/lua/goto-preview.lua:79: Cursor position outside buffer
. Seems setting the cursor is what is failing but I'm not sure why
from goto-preview.
Created that new issue to track what you're describing, let's continue there so I can merge the PR and close this one.
from goto-preview.
Related Issues (20)
- Highlight group? HOT 2
- Different color theme in flat window HOT 3
- [BUG] Current buffer closes with preview if the preview and parent buffer are the same file HOT 2
- [FEATURE] Explain vim-plug setup HOT 3
- [FEATURE] Add a wiki for repo HOT 4
- [BUG] preview window triggers twice in vue 3 router file HOT 2
- [BUG] Fails if you haven't done regular go to definition first HOT 3
- [Suggestion] Remove vim.inspect HOT 2
- [FEATURE] Closing `n+1` preview should move the focus to the `n` preview HOT 4
- Can't use goto-preview while it is installed, how to troubleshoot it ? [BUG] HOT 4
- Keep the last directory structure after close the preview window HOT 7
- [FEATURE] Allow not to automatically initialize telescope HOT 1
- Change border color HOT 1
- How to close only one preview and how to open focused preview in current split but new buffer?
- Setting on `post_open_hook` will be shared if I split window? HOT 1
- [BUG] attempt to index field 'lsp_configs' (a nil value) HOT 9
- [FEATURE]: 'Enter' key in a preview window to close all preview windows and go to the definition,refs, etc HOT 6
- Filename in float window
- Getting "Invalid key" error when go to definition HOT 6
- [FEATURE]: Toggle single preview window and show definition automatically when cursor moving in source window. HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from goto-preview.