Consider using JavaExec when calling DataNucleus about datanucleus-gradle-plugin HOT 3 OPEN

Hi @thc202 ,

Thanks for your feedback.

The DataNucleusEnhancer and SchemaTool use System#exit in case of errors which ends up terminating the Gradle daemon, with JavaExec it is created a different process and the exit calls wouldn't affect the Gradle daemon.

Is there are specific reason why they are being called programmatically instead of as command line?

Happy to provide a pull request if this is acceptable.

No specific reason for this, except that I tried to use the methods already available in datanucleus-core.
I think only the schema tool tasks explicitly call the datanucleus-core SchemaTool main method, which indeed might end up calling System#exit:

On the other hand, I don't think the enhancer tasks have a similar issue. They instantiate a new DataNucleusEnhancer object, which contains methods to perform the operations needed, without calling the main method.

Anyways, thanks for pointing this out. This definitely makes sense. So if you get a chance to contribute a PR, that would be greatly appreciated.
Thanks.

from datanucleus-gradle-plugin.

While not directly related to this issue, have you considered using lazy configuration and also task configuration avoidance?

Not yet, but any contribution is more than welcome :-)
I've created #331 and #332 to help keep track of these.
Thanks.

from datanucleus-gradle-plugin.

While not directly related to this issue, have you considered using lazy configuration and also task configuration avoidance?

from datanucleus-gradle-plugin.