Giter Club home page Giter Club logo

Comments (3)

thijstriemstra avatar thijstriemstra commented on September 15, 2024 1

It should import luma.core.interface.serial.noop instead (since v1.0), so you're right, this is a bug (and I'm surprised this wasn't caught by unit tests before).

See https://github.com/rm-hull/luma.core/blob/master/luma/core/interface/serial.py

from luma.emulator.

thijstriemstra avatar thijstriemstra commented on September 15, 2024

Tests are actually catching the error, I guess they just haven't been run since luma.core 1.0:

____________________________________ ERROR collecting tests/test_gifanim.py _____________________________________
ImportError while importing test module '/home/thijs/luma.emulator/tests/test_gifanim.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/test_gifanim.py:16: in <module>
    from luma.emulator.device import gifanim
luma/emulator/device.py:20: in <module>
    from luma.core.serial import noop
E   ImportError: No module named serial

from luma.emulator.

rm-hull avatar rm-hull commented on September 15, 2024

I pushed v0.2.5 of luma.emulator to pypi with @thijstriemstra's fix

from luma.emulator.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.