Giter Club home page Giter Club logo

Comments (8)

ColinFay avatar ColinFay commented on May 31, 2024 1

I second that idea.

Would be nice to have an error message here suggesting to launch find_chrome():

> chrome <- Chrome$new() 
Running  --no-first-run --headless \
  '--user-data-dir=/Users/colin/Library/Application Support/r-crrri/chrome-data-dir-zlfusejq' \
  '--remote-debugging-port=9222'
Error: Cannot launch Chrome. Please check your system configuration.

I feel like Please check your system configuration. is a little bit cryptic, when what the function needs is the path to the chrome bin, so something like:

Error: Cannot launch Chrome. Please add the path to your Chrome bin, you can trry and find it with `find_chrome()`.

Depending on pagedown() for that only function seems a little bit too much though.

from crrri.

cderv avatar cderv commented on May 31, 2024 1

We still are missing a download_chromium like in decapitated:
https://github.com/hrbrmstr/decapitated/blob/master/R/download-chromium.R

@hrbrmstr you suggested a fix version in decapitated from googleapi.
I found later this website (https://chromium.woolyss.com/#notes) where there are several portable versions that where useful for me on windows. what do you think of this source ?
We could either document the installation there or update you download_chromium function.

from crrri.

RLesur avatar RLesur commented on May 31, 2024

@ColinFay Thanks for the suggestion!

from crrri.

cderv avatar cderv commented on May 31, 2024

@RLesur do you think we can borrow the find_chrome function ? or should we rewrote it our way ?
It seems useful and that configuring is not enough for users.

from crrri.

RLesur avatar RLesur commented on May 31, 2024

pagedown license is MIT. There is no problem in reusing the source with appropriate credits.
The only point is that we should use a different function name to avoid conflicts.

from crrri.

cderv avatar cderv commented on May 31, 2024

This confirms what thought. 👍
name idea:

  • chrome_find ? 😄
  • find_chrome_binary ?
  • guess_chrome_path ?

from crrri.

RLesur avatar RLesur commented on May 31, 2024

+1 for find_chrome_binary()

from crrri.

cderv avatar cderv commented on May 31, 2024

@ColinFay there is now a find_chrome_binary() function that will guess like that the one in pagedown but also use HEADLESS_CHROME env var if set.

from crrri.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.