Comments (8)
I second that idea.
Would be nice to have an error message here suggesting to launch find_chrome()
:
> chrome <- Chrome$new()
Running --no-first-run --headless \
'--user-data-dir=/Users/colin/Library/Application Support/r-crrri/chrome-data-dir-zlfusejq' \
'--remote-debugging-port=9222'
Error: Cannot launch Chrome. Please check your system configuration.
I feel like Please check your system configuration.
is a little bit cryptic, when what the function needs is the path to the chrome bin, so something like:
Error: Cannot launch Chrome. Please add the path to your Chrome bin, you can trry and find it with `find_chrome()`.
Depending on pagedown()
for that only function seems a little bit too much though.
from crrri.
We still are missing a download_chromium
like in decapitated:
https://github.com/hrbrmstr/decapitated/blob/master/R/download-chromium.R
@hrbrmstr you suggested a fix version in decapitated from googleapi.
I found later this website (https://chromium.woolyss.com/#notes) where there are several portable versions that where useful for me on windows. what do you think of this source ?
We could either document the installation there or update you download_chromium function.
from crrri.
@ColinFay Thanks for the suggestion!
from crrri.
@RLesur do you think we can borrow the find_chrome
function ? or should we rewrote it our way ?
It seems useful and that configuring is not enough for users.
from crrri.
pagedown license is MIT. There is no problem in reusing the source with appropriate credits.
The only point is that we should use a different function name to avoid conflicts.
from crrri.
This confirms what thought. 👍
name idea:
chrome_find
? 😄find_chrome_binary
?guess_chrome_path
?
from crrri.
+1 for find_chrome_binary()
from crrri.
@ColinFay there is now a find_chrome_binary()
function that will guess like that the one in pagedown but also use HEADLESS_CHROME
env var if set.
from crrri.
Related Issues (20)
- Logic for returning results from a function that get XHR calls response body HOT 3
- How to send some value to web page and get the output saved or retrieved as dataframe HOT 12
- Can't create chromium instance on debian linux 10 HOT 1
- chrome_read_html HOT 6
- Run in Github Actions HOT 4
- Is possible to extract data from Power BI dashboard using crrri package?
- Select Dropdown not working
- Upload File HOT 1
- Cannot open URL 'http://localhost:9222/json/new': HTTP status was '405 Method Not Allowed' HOT 4
- websites that don't like to be scraped HOT 1
- Document R6 class using new roxygen feature HOT 5
- Finalize a stable version ? HOT 1
- Add support and document about New Edge Chromium HOT 1
- Allow to load user profile in non-headless mode HOT 8
- add some more default flags to launch chromium
- Allow children to close parent connection HOT 2
- Suggestion: automatically find a free port if the specified is not. HOT 2
- Purge crrrri cache HOT 1
- switch CI to Github Actions HOT 2
- R 4.0.0 now runs donttest example
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crrri.