Firefox? about ad-accelerator HOT 4 OPEN

First of all , I want to say thanks to @rkk3 who initiate this skip idea and since that day I saw post on HN , I installed extension on Vivaldi browser and it was working well. I just read there's another extension launched as a copy of this one and I'm so sorry to hear that they didn't give enough credit to your idea.

+1 for Firefox browser support.

from ad-accelerator.

I created a Fork to see what changes would need to be made to make it work in Firefox. Turns out you only need to change the "service_worker" key to "scripts" inside the manifest.json. This would be a breaking change for Chrome so @rkk3 would have to make a separate branch for it.

from ad-accelerator.

@sgreer2 thanks for taking a look. I had checked a few weeks ago as well and thought it seemed pretty easy too but there were some changes that would be incompatible (the manifest file as well IIRC) between both Chrome and FF.

Any idea on best practices for structuring the project if there are browser specific changes? A separate branch seems reasonable

from ad-accelerator.

@rkk3 I think a separate branch for Firefox would probably be the best option. Then with every update of the main branch you could just rebase the Firefox branch.

from ad-accelerator.