Giter Club home page Giter Club logo

Comments (4)

rjaros avatar rjaros commented on September 15, 2024

Hello,

When using state binding all children elements of the container (the stack panel) are removed and disposed on every state change. In your case you are trying to reuse the same instances of button and text. But after first click the Text component is disposed and can't be used (it's still there but rendered as an empty div).

The correct way to work with state binding is using DSL. In this case the children components are disposed too, but they are also recreated (usually with a new state).

from kvision.

CodeServant avatar CodeServant commented on September 15, 2024

So, If i want to switch between panels via reference to the Component it should be like this. Thats works for me. So it is officialy correct?

data class StackPanelBindings(
    val tx: Text,
    val btn: Button
)

val index = ObservableValue(
    StackPanelBindings(
        Text(floating = true, label = "this is label"),
        Button(text = "Click me!")
    ) 
)

stackPanel().bind(
    index
) {binding ->
    add(binding.btn)
    add(binding.tx)

    binding.btn.onClick {
        activeChild = binding.tx
    }
    activeChild = binding.btn
}

from kvision.

rjaros avatar rjaros commented on September 15, 2024

No. I wouldn't call it correct.
You need to ask yourself if (and why) you need instances of Text and Button components created manually. In general it should not be required, in fact you don't even need stack panel for your goal. You can just do this:

            val index = ObservableValue(0) // 0  - show button first

            simplePanel().bind(index) {
                if (it == 0) {
                    button(text = "Click me!") {
                        onClick {
                            index.value = 1
                        }
                    }
                } else {
                    text(floating = true, label = "this is label")
                }
            }
            span().bind(index) {
                +"${it}"
            }

If you want to access internal instances from outside you can declare a variable:

            val index = ObservableValue(0) // 0  - show button first

            var text: Text? = null
            simplePanel().bind(index) {
                if (it == 0) {
                    button(text = "Click me!") {
                        onClick {
                            index.value = 1
                        }
                    }
                } else {
                    text = text(floating = true, label = "this is label")
                }
            }
            span().bind(index) {
                +"${it}"
            }
            button("set new value") {
                onClick {
                    text?.value = "new value"
                }
            }

Still there are cases when externally defined components can be useful. But for such cases you should not use state binding, because you don't want to dispose and recreate you components. You just want to switch which is visible, and StackPanel is the right tool for this - just change activeIndex property and it will work.

            val index = ObservableValue(0) // 0  - show button first

            val txChild = Text(floating = true, label = "this is label")
            val btn = Button(text = "Click me!") {
                onClick {
                    index.value = 1
                }
            }

            stackPanel {
                add(btn)
                add(txChild)
                index.subscribe {
                    activeIndex = it
                }
            }

            span().bind(index) {
                +"${it}"
            }

from kvision.

CodeServant avatar CodeServant commented on September 15, 2024

ok I think I got this

from kvision.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.