Giter Club home page Giter Club logo

Comments (3)

skyzh avatar skyzh commented on August 15, 2024 2

Oh maybe you're referring to the sqllogictest binary. In this case,

sqllogictest-rs/src/main.rs

Lines 372 to 375 in f41a7bf

match row.get(i) {
Some(v) => write!(output, "{}", v).unwrap(),
None => write!(output, "NULL").unwrap(),
}

It is true that we didn't write anything for an empty string 🤣

from sqllogictest-rs.

skyzh avatar skyzh commented on August 15, 2024

I think this is controlled by the actual database implementation.

fn run(&mut self, sql: &str) -> Result<String, FakeDBError> {
if sql == "select * from example_basic" {
return Ok("Alice\nBob\nEve".into());
}
if sql.starts_with("create") {
return Ok("".into());
}
if sql.starts_with("insert") {
return Ok("".into());
}
if sql.starts_with("drop") {
return Ok("".into());
}
unimplemented!("unsupported SQL: {}", sql);
}

In sqllogictest's perspective, it simply compares and verifies a string.

from sqllogictest-rs.

kwannoel avatar kwannoel commented on August 15, 2024

Oh maybe you're referring to the sqllogictest binary. In this case,

sqllogictest-rs/src/main.rs

Lines 372 to 375 in f41a7bf
match row.get(i) {
Some(v) => write!(output, "{}", v).unwrap(),
None => write!(output, "NULL").unwrap(),
}

It is true that we didn't write anything for an empty string 🤣

Yes, that's what I was referring to, I think the sqllogictest binary needs to specially handle empty strings, similar to what it does for the NULL case above 🤣

from sqllogictest-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.