Giter Club home page Giter Club logo

Comments (5)

sorear avatar sorear commented on July 25, 2024

What about it?

from riscv-binutils-gdb.

palmer-dabbelt avatar palmer-dabbelt commented on July 25, 2024

We copied this symbol name from MIPS, but Andrew realized it's probably not a good idea as it's not in any protected namespace. While it's probably OK for most software because of the MIPS heritage, we figured we might as well change it while we still can.

The plan was to go figure out what other people are doing, rule out all the bad names (like _gp), and then ask you if you had any opinions. You're welcome to do a bit more work if you want... :).

from riscv-binutils-gdb.

aswaterman avatar aswaterman commented on July 25, 2024

As we discussed earlier, it is probably benign, since we are not the only ABI that uses this name. But if we do change it, it should be to something with two underscores.

from riscv-binutils-gdb.

vapier avatar vapier commented on July 25, 2024

a simple switch like __gp would be good to do early. if possible, using a symbol name that isn't valid from the C ABI might be worth investigating. like __gp$ or __global_pointer$.

from riscv-binutils-gdb.

palmer-dabbelt avatar palmer-dabbelt commented on July 25, 2024

Fixed in #56, hopefully it's OK for upstream.

from riscv-binutils-gdb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.