Cannot use with Cashier about laravel-subscriptions HOT 15 CLOSED

Didn't try both together before, but PRs are always welcome 😉

from laravel-subscriptions.

I fixed it using the php documentation. It is ugly, but solves the problem in the official way.

use Billable, HasSubscriptions {
      Billable::newSubscription insteadof HasSubscriptions;
      Billable::subscription insteadof HasSubscriptions;
      Billable::subscriptions insteadof HasSubscriptions;
      HasSubscriptions::newSubscription as _newSubscription;
      HasSubscriptions::subscription as _subscription;
      HasSubscriptions::subscriptions as _subscriptions;
   }

from laravel-subscriptions.

@Omranic a PR probably would use new functions names, what you think about that?

from laravel-subscriptions.

A made a PR #74 without breaking changes.

from laravel-subscriptions.

This is now fixed in 3eedf73

from laravel-subscriptions.

@Omranic Still have the same problem.

from laravel-subscriptions.

Not tested yet. But is this a breaking change?

from laravel-subscriptions.

@Bariskau what problem do you still have, can you please explain in more details..

@insign Yes, function and trait renames.

from laravel-subscriptions.

@Omranic Cashier basically just takes care of the stripe payment part. We have to create user limitations or plan information ourselves. That takes a lot of time. This package offers them, it just can't get paid. We already handle this with cashier. For this reason, it support will be good for many people to work with cashier.

If support will not be given, I recommend this package to interested people. You can manage the quota through Cashier.

from laravel-subscriptions.

@Bariskau TBH I still didn't get your points, so what's the issue related to this package exactly?

What you explained is correct, and it's mentioned already in the docs, this package doesn't handle payment.

from laravel-subscriptions.

@Bariskau is right. HasSubscriptions trait from laravel-subscriptions keeps colliding with Billable trait from Cashier.

It's sad that this issue is so old, had many major new version, and it keeps the same function names...

from laravel-subscriptions.

OK, now I see why's the complains! All these issues were already fixed long time ago, but wasn't merged into master branch, it was staying in the develop and not tagged yet. I've tagged a new release now v6.0.1 which should include all of these fixes! 🚨⚠️ WARNING: BACKWARD INCOMPATIBLE

Let me know if there's still anything conflicting with Cashier.

from laravel-subscriptions.

from laravel-subscriptions.

Yes, we should be following semver, and the major changes in v6.x was meant to be this change mainly, hence the major release, however I just noticed it wasn't merged into it. So I tagged a new minor version, which is probably not kosher from a semver perspective!

Anyway, the backward incompatibility issues is because of the function renames that solve the previous Cashier conflicts, nothing else.

from laravel-subscriptions.

Thank you, now looks great!

from laravel-subscriptions.