Giter Club home page Giter Club logo

Comments (6)

marcosrocha85 avatar marcosrocha85 commented on May 31, 2024 1

Pull request #16 created.

from jkanban.

marcosrocha85 avatar marcosrocha85 commented on May 31, 2024

Tested a alert on dropEl when moving the "Another card" to it's same position and noticed that the alert didn't popped out. Maybe that's a bug from dragula?

from jkanban.

riktar avatar riktar commented on May 31, 2024

@marcosrocha85 When you drag an element in the same position it's not a complete drag but an "undo" move so it's correct that the alert didn't popped out.

from jkanban.

marcosrocha85 avatar marcosrocha85 commented on May 31, 2024

@riktar ok, but how we can fix the disabled boards when "undo"? I'm trying to evaluate the code but my browser is saying require is not defined.

from jkanban.

marcosrocha85 avatar marcosrocha85 commented on May 31, 2024

Basically the fix was call new function enableAllBoards on Dragula's cancel event. Here it is:

@@ -92,10 +92,13 @@ var dragula = require('dragula');
 
                 //Init Drag Item
                 self.drake = self.dragula(self.boardContainer, function () {
                     revertOnSpill: true
                 })
+                    .on('cancel', function(el, container, source) {
+                        self.enableAllBoards();
+                    })
                     .on('drag', function (el, source) {
                         el.classList.add('is-moving');
                         var boardJSON = __findBoardJSON(source.parentNode.dataset.id);
                         if (boardJSON.dragTo !== undefined) {
                             self.options.boards.map(function (board) {
@@ -113,17 +116,12 @@ var dragula = require('dragula');
                         self.options.dragendEl(el);
                         if (el !== null && typeof(el.dragendfn) === 'function')
                             el.dragendfn(el);
                     })
                     .on('drop', function (el, target, source, sibling) {
+                        self.enableAllBoards();
 
-                        var allB = document.querySelectorAll('.kanban-board');
-                        if (allB.length > 0 && allB !== undefined) {
-                            for (var i = 0; i < allB.length; i++) {
-                                allB[i].classList.remove('disabled-board');
-                            }
-                        }
                         var boardJSON = __findBoardJSON(source.parentNode.dataset.id);
                         if (boardJSON.dragTo !== undefined) {
                             if (boardJSON.dragTo.indexOf(target.parentNode.dataset.id) === -1 && target.parentNode.dataset.id !== source.parentNode.dataset.id) {
                                 self.drake.cancel(true)
                             }
@@ -136,10 +134,19 @@ var dragula = require('dragula');
                         }
                     })
             }
         };
 
+        this.enableAllBoards = function() {
+            var allB = document.querySelectorAll('.kanban-board');
+            if (allB.length > 0 && allB !== undefined) {
+                for (var i = 0; i < allB.length; i++) {
+                    allB[i].classList.remove('disabled-board');
+                }
+            }
+        };
+
         this.addElement = function (boardID, element) {
             var board = self.element.querySelector('[data-id="' + boardID + '"] .kanban-drag');
             var nodeItem = document.createElement('div');
             nodeItem.classList.add('kanban-item');
             if (element.id) {

from jkanban.

riktar avatar riktar commented on May 31, 2024

Resolved in pull request #16

from jkanban.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.