Comments (6)
Pull request #16 created.
from jkanban.
Tested a alert on dropEl when moving the "Another card" to it's same position and noticed that the alert didn't popped out. Maybe that's a bug from dragula?
from jkanban.
@marcosrocha85 When you drag an element in the same position it's not a complete drag but an "undo" move so it's correct that the alert didn't popped out.
from jkanban.
@riktar ok, but how we can fix the disabled boards when "undo"? I'm trying to evaluate the code but my browser is saying require is not defined.
from jkanban.
Basically the fix was call new function enableAllBoards on Dragula's cancel event. Here it is:
@@ -92,10 +92,13 @@ var dragula = require('dragula');
//Init Drag Item
self.drake = self.dragula(self.boardContainer, function () {
revertOnSpill: true
})
+ .on('cancel', function(el, container, source) {
+ self.enableAllBoards();
+ })
.on('drag', function (el, source) {
el.classList.add('is-moving');
var boardJSON = __findBoardJSON(source.parentNode.dataset.id);
if (boardJSON.dragTo !== undefined) {
self.options.boards.map(function (board) {
@@ -113,17 +116,12 @@ var dragula = require('dragula');
self.options.dragendEl(el);
if (el !== null && typeof(el.dragendfn) === 'function')
el.dragendfn(el);
})
.on('drop', function (el, target, source, sibling) {
+ self.enableAllBoards();
- var allB = document.querySelectorAll('.kanban-board');
- if (allB.length > 0 && allB !== undefined) {
- for (var i = 0; i < allB.length; i++) {
- allB[i].classList.remove('disabled-board');
- }
- }
var boardJSON = __findBoardJSON(source.parentNode.dataset.id);
if (boardJSON.dragTo !== undefined) {
if (boardJSON.dragTo.indexOf(target.parentNode.dataset.id) === -1 && target.parentNode.dataset.id !== source.parentNode.dataset.id) {
self.drake.cancel(true)
}
@@ -136,10 +134,19 @@ var dragula = require('dragula');
}
})
}
};
+ this.enableAllBoards = function() {
+ var allB = document.querySelectorAll('.kanban-board');
+ if (allB.length > 0 && allB !== undefined) {
+ for (var i = 0; i < allB.length; i++) {
+ allB[i].classList.remove('disabled-board');
+ }
+ }
+ };
+
this.addElement = function (boardID, element) {
var board = self.element.querySelector('[data-id="' + boardID + '"] .kanban-drag');
var nodeItem = document.createElement('div');
nodeItem.classList.add('kanban-item');
if (element.id) {
from jkanban.
Resolved in pull request #16
from jkanban.
Related Issues (20)
- Is there any way to collapse kanban board? HOT 2
- Checkbox is not working on board HOT 21
- dropEl function for sorting boards HOT 4
- Uncaught TypeError: Cannot read properties of undefined (reading 'dragTo') HOT 1
- Header of kanban boards - adding a button HOT 5
- Footer button to add items on a specific board HOT 8
- HEX colors for boards headers HOT 2
- Browser context menu disabled - how to enable. HOT 1
- Which js minification software does jkanban use HOT 2
- can i add Kebab menu to kanban-item to i can drag item to anther id ??? HOT 2
- importing jkanban/dist/jkanban.min.js file throws an error HOT 4
- How to get item id when clicked HOT 1
- JKanban drag and move not working properly when we use the mobile view HOT 3
- replaceElement API Issue cause click function fired multiple
- Pagination support HOT 4
- collapsible Board
- Disabled element completly not interactible HOT 1
- import problem with vite HOT 2
- Width
- Uncaught ReferenceError: global is not defined HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jkanban.